Page MenuHomePhabricator

[minor] Recent Changes/Watchlist: Enabled "Set as default" option pushes "Create default filter" button to a new line
Open, Needs TriagePublicBUG REPORT

Description

The issue is present on cawiki and dewiki.

  1. On Special:RecentChanges (Special:Watchlist) click on the bookmark icon to save a filter.
  2. The dialog box will be displayed - the bookmark icon is displayed on a separate line (may be it's worth fixing it too).

Screen Shot 2019-02-27 at 2.28.48 PM.png (303×467 px, 30 KB)

  1. Click in the check box "Set as defaul", "Create default filter" button will be pushed below 'Cancel'.

Screen Shot 2019-02-27 at 4.06.43 PM.png (396×355 px, 30 KB)

The same issue is present on dewiki:

Screen Shot 2019-02-27 at 2.28.39 PM.png (354×400 px, 31 KB)

Event Timeline

@srishakatux , i am outreachy applicant and i would like to contribute to this task, assign it to me. Thanks

kostajh added a project: patch-welcome.
kostajh changed the subtype of this task from "Task" to "Bug Report".
kostajh added a subscriber: kostajh.

Growth-Team talked about this today. We'd like the solution for this to be keeping the button message consistent, so

  1. User sees "Create filter"
  2. Users checks the box for "Set as default"
  3. User should still see "Create filter", instead of "Create default filter"

One could also consider making the dialog a bit wider.

@Rachealnamaara: Hi, is there anything that others could help with? Are you still working (or still plan to work) on this issue?