Page MenuHomePhabricator
Create Task
Maniphest T217671

Use baserevid in Senses editing
Closed, ResolvedPublic
Actions

Description

Same AC as in parent ticket

Details

SubjectRepoBranchLines +/-
Use baserevid in Senses editingmediawiki/extensions/WikibaseLexememaster+23 -15
Customize query in gerrit

Related Objects
Search...

Event Timeline

• alaa_wmde created this task.Mar 5 2019, 4:25 PM
Addshore triaged this task as Medium priority.Mar 5 2019, 4:27 PM
gerritbot subscribed.Mar 19 2019, 3:26 PM

Change 497517 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/WikibaseLexeme@master] Use baserevid in Senses editing

https://gerrit.wikimedia.org/r/497517

gerritbot added a project: Patch-For-Review.Mar 19 2019, 3:26 PM
Ladsgroup claimed this task.Mar 19 2019, 4:35 PM
Ladsgroup moved this task from To Do (prioritised from top to bottom) to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptMar 19 2019, 4:35 PM
Ladsgroup mentioned this in rEWLE64d1b4badfae: Use baserevid in Senses editing.Mar 21 2019, 12:41 AM
Ladsgroup mentioned this in rEWLE47c6a927f2df: Use baserevid in Senses editing.
Ladsgroup mentioned this in rEWLE55dbdacca890: Use baserevid in Senses editing.
Addshore mentioned this in rEWLEe7a4c0b947ab: Use baserevid in Senses editing.Mar 27 2019, 10:21 AM
• alaa_wmde added a comment.EditedMar 27 2019, 4:49 PM

This cane be merged even before T217243 right?

Ladsgroup added a comment.Apr 2 2019, 4:32 PM
In T217671#5062795, @alaa_wmde wrote:

This cane be merged even before https://phabricator.wikimedia.org/T218115 right?

I don't know how these two tickets are dependent.

• alaa_wmde added a comment.Apr 2 2019, 4:33 PM
In T217671#5078198, @Ladsgroup wrote:
In T217671#5062795, @alaa_wmde wrote:

This cane be merged even before https://phabricator.wikimedia.org/T218115 right?

I don't know how these two tickets are dependent.

Wrong task sorry .. fixed

Ladsgroup added a comment.Apr 2 2019, 4:40 PM

Then it should be fine, it would just gives a warning "unrecognized parameter" and ignores it like https://meta.wikimedia.org/w/api.php?action=antispoof&username=Foo&baserev=foo

noarave moved this task from Peer Review to Stalled/Waiting on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Apr 12 2019, 10:03 AM
Ladsgroup moved this task from Stalled/Waiting to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.May 8 2019, 11:55 AM
Ladsgroup mentioned this in rEWLE92c35adbf564: Use baserevid in Senses editing.May 9 2019, 9:30 AM
WMDE-leszek moved this task from Peer Review to Stalled/Waiting on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.May 27 2019, 1:45 PM
WMDE-leszek subscribed.

Requires the issue reported in T223207 to be fixed first.

Addshore moved this task from incoming to in progress on the Wikidata board.Jun 21 2019, 11:28 PM
Ladsgroup added a comment.Jul 4 2019, 12:56 PM
In T217671#5214778, @WMDE-leszek wrote:

Requires the issue reported in T223207 to be fixed first.

We have a decision now, stop sending it in wbladdsense but add baserevid in the rest.

Ladsgroup moved this task from Stalled/Waiting to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jul 4 2019, 12:56 PM
• alaa_wmde mentioned this in T225071: Add baserevid to wbleditsenseelements API module.Jul 5 2019, 12:51 PM
• alaa_wmde moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jul 8 2019, 3:22 PM
gerritbot added a comment.Jul 8 2019, 3:50 PM

Change 497517 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Use baserevid in Senses editing

https://gerrit.wikimedia.org/r/497517

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.13; 2019-07-09).Jul 8 2019, 4:01 PM
Maintenance_bot removed a project: Patch-For-Review.Jul 8 2019, 4:11 PM
Rosalie_WMDE moved this task from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jul 26 2019, 1:33 PM
• alaa_wmde closed this task as Resolved.Oct 1 2019, 2:47 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL