Mobile VE doesn't use DB title for RESTBase load, resulting in a 301 redirect
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Esanders
	Mar 7 2019, 11:32 AM

Description

We should be using mw.Title#getPrefixedDb

Details

Subject	Repo	Branch	Lines +/-
currentPage should reflect currentPage not relevant title	mediawiki/extensions/MobileFrontend	master	+13 -6
Fix page.title to use mw.Title#getPrefixedText instead of regex	mediawiki/extensions/MobileFrontend	master	+16 -11
ve.init.mw.ArticleTargetLoader: Better document `pageName` parameters	mediawiki/extensions/VisualEditor	master	+1 -1

Customize query in gerrit

Related Objects

Mentioned In: T230927: AMC Outreach Drawer encouraging me to turn on advanced mode sends me from Special:Homepage to my user page
T212137: Check impacts of mobile VE load screen improvements
T209052: Load page content in parallel with VE code on Mobile with ArticleTargetLoader
T214450: Analyze impact of parallel loading of page content and mobile visual editor code

Event Timeline

Esanders created this task.Mar 7 2019, 11:32 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 7 2019, 11:32 AM

Esanders mentioned this in T214450: Analyze impact of parallel loading of page content and mobile visual editor code.Mar 7 2019, 11:32 AM

Change 494907 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/MobileFrontend@master] Fix page.title to use mw.Title#getPrefixedText instead of regex

https://gerrit.wikimedia.org/r/494907

gerritbot added a project: Patch-For-Review.Mar 7 2019, 11:35 AM

Esanders moved this task from Incoming to Code review on the VisualEditor (Current work) board.Mar 7 2019, 11:35 AM

• ppelberg mentioned this in T209052: Load page content in parallel with VE code on Mobile with ArticleTargetLoader.Mar 8 2019, 12:08 AM

Change 494907 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Fix page.title to use mw.Title#getPrefixedText instead of regex

https://gerrit.wikimedia.org/r/494907

matmarex moved this task from Code review to QA on the VisualEditor (Current work) board.Mar 8 2019, 10:39 PM

Change 495407 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] ve.init.mw.ArticleTargetLoader: Better document pageName parameters

https://gerrit.wikimedia.org/r/495407

Change 495407 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] ve.init.mw.ArticleTargetLoader: Better document pageName parameters

https://gerrit.wikimedia.org/r/495407

matmarex added a project: Editing QA.Mar 9 2019, 1:27 AM

matmarex removed a project: Editing QA.Mar 9 2019, 1:30 AM

matmarex moved this task from QA to Engineering QA on the VisualEditor (Current work) board.

• ppelberg mentioned this in T212137: Check impacts of mobile VE load screen improvements.Mar 11 2019, 9:13 PM

Verified on mediawiki.org:

Esanders moved this task from Engineering QA to Product owner review on the VisualEditor (Current work) board.Mar 14 2019, 3:54 PM

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.22; 2019-03-19).Mar 16 2019, 10:02 PM

Game of Thrones, eh?

Jdlrobson mentioned this in T230927: AMC Outreach Drawer encouraging me to turn on advanced mode sends me from Special:Homepage to my user page.Aug 21 2019, 4:36 PM

Maintenance_bot removed a project: Patch-For-Review.Aug 21 2019, 5:10 PM

Change 531743 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] currentPage should reflect currentPage not relevant title

https://gerrit.wikimedia.org/r/531743

gerritbot added a project: Patch-For-Review.Aug 22 2019, 8:08 PM

Change 531743 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] currentPage should reflect currentPage not relevant title

https://gerrit.wikimedia.org/r/531743

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.21; 2019-09-03).Aug 27 2019, 10:00 PM

Maintenance_bot removed a project: Patch-For-Review.Aug 27 2019, 10:10 PM