As shown in T206228, we are waiting ~1s before we start loading the page data/metadata, while the VE code loads. If we load this is parallel like we do on desktop page load times would be greatly improved.
Description
Details
Status | Subtype | Assigned | Task | ||
---|---|---|---|---|---|
Resolved | None | T214450 Analyze impact of parallel loading of page content and mobile visual editor code | |||
Resolved | Esanders | T209052 Load page content in parallel with VE code on Mobile with ArticleTargetLoader |
Event Timeline
We should check with @Neil_P._Quinn_WMF that we have reasonable page load timings for Mobile VE before we deploy any improvements.
Change 472461 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/skins/MinervaNeue@master] VE: Load HTML in parallel with modules
Change 472466 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/MobileFrontend@master] VE: Load all VE modules at the same time
Change 472461 abandoned by Esanders:
VE: Load HTML in parallel with modules
Reason:
Squashed into Ib0ff6636a5d0f2033b8952ba26aecce5698db893
Change 472466 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] VE: Load all VE modules at the same time
Should probably compare before/after numbers as part of QA. I don't know where they are logged.
(Neil filed T214450: Analyze impact of parallel loading of page content and mobile visual editor code to investigate)
We now have mobile timing values in the EditAttemptStep data stream—I did some basic checks in T205166#4886384 so it looks like the data is there.
I think this is actually not complete. We forgot half of the patch. https://gerrit.wikimedia.org/r/472461 was abandoned and supposed to be squashed into the other patch https://gerrit.wikimedia.org/r/472466, but AFAICS it was not, and I don't see that code on master.
Change 486193 had a related patch set uploaded (by Bartosz Dziewoński; owner: Esanders):
[mediawiki/extensions/MobileFrontend@master] VE: Load HTML in parallel with modules
Change 486193 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] VE: Load HTML in parallel with modules
Change 488494 had a related patch set uploaded (by Bartosz Dziewoński; owner: Esanders):
[mediawiki/extensions/MobileFrontend@wmf/1.33.0-wmf.16] VE: Load HTML in parallel with modules
Scheduled for SWAT: https://wikitech.wikimedia.org/wiki/Deployments#deploycal-item-20190206T1700
(We wanted to have this live like two weeks ago…)
Change 488494 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@wmf/1.33.0-wmf.16] VE: Load HTML in parallel with modules
Mentioned in SAL (#wikimedia-operations) [2019-02-06T17:49:47Z] <thcipriani@deploy1001> Synchronized php-1.33.0-wmf.16/extensions/MobileFrontend: SWAT: [[gerrit:488494|VE: Load HTML in parallel with modules]] T209052 (duration: 00m 57s)
Change 488523 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/MobileFrontend@master] mobile.init/editor: Don't create loading overlay if we're not going to use it
Change 488523 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] mobile.init/editor: Don't create loading overlay if we're not going to use it
Change 488591 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/MobileFrontend@wmf/1.33.0-wmf.16] mobile.init/editor: Don't create loading overlay if we're not going to use it
Change 488591 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@wmf/1.33.0-wmf.16] mobile.init/editor: Don't create loading overlay if we're not going to use it
Mentioned in SAL (#wikimedia-operations) [2019-02-07T00:47:14Z] <twentyafterfour> syncing commit rEMFRdd8654ac9b3f for Bug: T209052
I wanted to compare the performance using the production data as part of QA:
…but actually, we should probably do that in T214450: Analyze impact of parallel loading of page content and mobile visual editor code.