Page MenuHomePhabricator
Create Task
Maniphest T217923

Help panel: search mode can have question footer
Closed, ResolvedPublicBUG REPORT
Actions

Description

It is possible to end up in search mode with the question footer visible by doing the following:

  1. Open the help panel
  2. Enter search mode by focusing the search input and entering some text
  3. Close the help panel using the "X" button
  4. Open the help panel again

Screen Shot 2019-03-08 at 15.54.56.png (430×501 px, 54 KB)

Details

SubjectRepoBranchLines +/-
Improve encapsulation of HelpPanelSearchWidgetmediawiki/extensions/GrowthExperimentsmaster+48 -20
Customize query in gerrit

Related Objects

Event Timeline

SBisson created this task.Mar 8 2019, 8:58 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 8 2019, 8:58 PM
SBisson changed the subtype of this task from "Task" to "Bug Report".Mar 8 2019, 8:58 PM
SBisson edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.Mar 15 2019, 12:30 PM
gerritbot subscribed.Mar 15 2019, 12:31 PM

Change 496762 had a related patch set uploaded (by Sbisson; owner: Sbisson):
[mediawiki/extensions/GrowthExperiments@master] Improve encapsulation of HelpPanelSearchWidget

https://gerrit.wikimedia.org/r/496762

gerritbot added a project: Patch-For-Review.Mar 15 2019, 12:31 PM
SBisson claimed this task.Mar 15 2019, 12:31 PM
SBisson moved this task from Incoming to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.

Fixed it by accident when working on the help panel refactor for T216631: Homepage: mentorship module

SBisson mentioned this in rEGRE6df135b16934: Improve encapsulation of HelpPanelSearchWidget.Mar 15 2019, 12:33 PM
kostajh moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Mar 15 2019, 2:10 PM
gerritbot added a comment.Mar 15 2019, 2:18 PM

Change 496762 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Improve encapsulation of HelpPanelSearchWidget

https://gerrit.wikimedia.org/r/496762

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.22; 2019-03-19).Mar 17 2019, 4:02 AM
Etonkovidova closed this task as Resolved.Mar 18 2019, 9:44 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL