Page MenuHomePhabricator
Create Task
Maniphest T218069

Multiple issues with scrolling in the "Add discussion" overlay on iOS render it unusable (can't save, can't type long messages)
Closed, ResolvedPublic
Actions

Description

There are multiple weird issues with scrolling in the "Add discussion" overlay.

  1. After tapping in the "What is on your mind?" field, the dialog header scrolls out of view and can't be scrolled back in. There is no way to tap "Save".

    header scrolls out of view.MP41 MBDownload


    There are two weird tricks that can bring the header back into view:
    1. Try scrolling down, then up, without letting go
    2. Tap the time on the top bar (which is a secret global shortcut to scroll to top)
  1. After typing in some long text, enough that scrolling would be necessary to view it all, you discover that the text input can't actually be scrolled up.

    cant scroll textarea.MP41 MBDownload


    I couldn't find any way to make it scroll. Seemingly it can be navigated by moving the selection (text cursor), but that is very error-prone.

Details

SubjectRepoBranchLines +/-
Restrict iOS scrolling emulation to overlays that need itmediawiki/extensions/MobileFrontendmaster+43 -18
Customize query in gerrit

Related Objects

Event Timeline

matmarex created this task.Mar 12 2019, 4:28 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 12 2019, 4:28 AM
gerritbot subscribed.Mar 12 2019, 4:59 AM

Change 495826 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/MobileFrontend@master] Overlay: Refactor code to prevent browser viewport scrolling on iOS

https://gerrit.wikimedia.org/r/495826

gerritbot added a project: Patch-For-Review.Mar 12 2019, 4:59 AM
ovasileva triaged this task as High priority.Mar 12 2019, 9:59 AM
ovasileva moved this task from Incoming to Needs Prioritization on the Web-Team-Backlog board.
ovasileva moved this task from Needs Prioritization to Upcoming on the Web-Team-Backlog board.Mar 13 2019, 4:07 PM
ovasileva moved this task from Upcoming to Needs Prioritization on the Web-Team-Backlog board.Mar 13 2019, 4:50 PM
Jdlrobson subscribed.Mar 13 2019, 9:19 PM

I tried to test this today, but am having trouble replicating. If this needs a real physical device to test the issue can you state so in the ticket description? I can't seem to replicate this bug in browserstack.

matmarex added a comment.Mar 13 2019, 9:33 PM

I don't know if it can be reproduced using Browserstack, I never used it. I encountered the issue on an actual iPhone SE running iOS 12.1.4, using the Safari browser.

ovasileva moved this task from Needs Prioritization to QA Tasks / Needs Reproduction on the Web-Team-Backlog board.Mar 14 2019, 4:38 PM
ovasileva added subscribers: Edtadros, ovasileva.

@Edtadros - perhaps you can take a look?

kaldari mentioned this in T211490: iPad: scrolling is broken when editing mobile site in source mode.Mar 14 2019, 6:12 PM
kaldari mentioned this in T218352: iOS Safari: Can't save edit in WikiText editor after entering edit summary.Mar 14 2019, 7:47 PM
gerritbot added a comment.Mar 14 2019, 7:58 PM

Change 496571 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] Restrict iOS scrolling emulation to overlays that need it

https://gerrit.wikimedia.org/r/496571

gerritbot added a comment.Mar 14 2019, 10:06 PM

Change 496571 merged by Jdlrobson:
[mediawiki/extensions/MobileFrontend@master] Restrict iOS scrolling emulation to overlays that need it

https://gerrit.wikimedia.org/r/496571

Jdlrobson added a comment.Mar 14 2019, 11:34 PM

This should have been fixed by https://gerrit.wikimedia.org/r/496571

Stashbot subscribed.Mar 15 2019, 5:59 PM

Mentioned in SAL (#wikimedia-operations) [2019-03-15T17:59:54Z] <thcipriani@deploy1001> Synchronized php-1.33.0-wmf.21/extensions/MobileFrontend: SWAT: [[gerrit:496827|iOS: Fix mobile editor]] T218069 T218062 T218352 T211490 T218062 T211491 T172877 (duration: 00m 54s)

Stashbot mentioned this in T218062: Dialogs in iOS mobile VE can't be scrolled.Mar 15 2019, 5:59 PM
Stashbot mentioned this in T211491: iPad Pro/iOS 12.1: cursor jumps out of view when editing mobile site in source mode.
Stashbot mentioned this in T172877: Backspace during mobile editing moves viewing window to the top.
ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.22; 2019-03-19).Mar 17 2019, 4:02 AM
matmarex closed this task as Resolved.Mar 25 2019, 6:58 PM

Seems to work correctly after that patch. I'm assuming you're not planning to do any QA or any other work on this, since it's in the "Backlog" project, so let's just close it.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits