Page MenuHomePhabricator
Create Task
Maniphest T218244

[Tracking] Migrate MobileContext::singleton() to a MobileFrontend.Context service
Closed, DeclinedPublic
Actions

Description

Per 95629c2, MobileContext::singleton() was moved to a MobileFrontend MW service (MobileFrontend.Context).

@pmiazga wants us to break this class into small services. So, the step one will be to replace all MobileContext::singleton() in the code base to the MobileFrontend.Context service and then break down the class into small services.

Details

SubjectRepoBranchLines +/-
Follow-up on Iee53988dcd: Use MobileContext service insteadmediawiki/extensions/MobileFrontendmaster+124 -87
Replace use of `MobileContext::singleton()` with MC servicemediawiki/extensions/MobileFrontendmaster+101 -68
specials: Use MobileFrontend.Context service where need bemediawiki/extensions/MobileFrontendmaster+47 -23
api: Start using MediaWikiServices for MobileContext classmediawiki/extensions/MobileFrontendmaster+12 -4
Customize query in gerrit

Related Objects
Search...

Event Timeline

xSavitar created this task.Mar 13 2019, 6:49 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 13 2019, 6:49 PM
xSavitar renamed this task from Migrate MobileContext::singleton() to a MediaWiki service to [Tracking] Migrate MobileContext::singleton() to a MediaWiki service.Mar 13 2019, 6:49 PM
gerritbot subscribed.Mar 13 2019, 6:50 PM

Change 496236 had a related patch set uploaded (by D3r1ck01; owner: Derick Alangi):
[mediawiki/extensions/MobileFrontend@master] api: [MCS] Start using MediaWikiServices for MobileContext class

https://gerrit.wikimedia.org/r/496236

gerritbot added a project: Patch-For-Review.Mar 13 2019, 6:50 PM
Jdlrobson added a parent task: T143189: [EPIC] Split MobileContext god object apart.Mar 13 2019, 6:58 PM
Jdlrobson awarded a token.
gerritbot added a comment.Mar 19 2019, 2:13 PM

Change 496236 had a related patch set uploaded (by D3r1ck01; owner: Derick Alangi):
[mediawiki/extensions/MobileFrontend@master] api: Start using MediaWikiServices for MobileContext class

https://gerrit.wikimedia.org/r/496236

Aklapper added a project: MobileFrontend.Mar 23 2019, 7:06 PM
• nray added a project: Web-Team-Backlog.Mar 25 2019, 11:47 PM
gerritbot added a comment.Mar 27 2019, 3:42 PM

Change 496236 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] api: Start using MediaWikiServices for MobileContext class

https://gerrit.wikimedia.org/r/496236

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.24; 2019-04-02).Mar 27 2019, 4:01 PM
ovasileva moved this task from Incoming to Needs Prioritization on the Web-Team-Backlog board.Mar 27 2019, 4:02 PM
xSavitar removed a project: Patch-For-Review.Mar 27 2019, 5:44 PM
gerritbot added a comment.Mar 27 2019, 8:02 PM

Change 499577 had a related patch set uploaded (by D3r1ck01; owner: Derick Alangi):
[mediawiki/extensions/MobileFrontend@master] specials: Use MobileFrontend.Context service where need be

https://gerrit.wikimedia.org/r/499577

gerritbot added a project: Patch-For-Review.Mar 27 2019, 8:02 PM
xSavitar renamed this task from [Tracking] Migrate MobileContext::singleton() to a MediaWiki service to [Tracking] Migrate MobileContext::singleton() to a MobileFrontend.Context service.Mar 27 2019, 8:03 PM
xSavitar triaged this task as Medium priority.
xSavitar updated the task description. (Show Details)
Jdlrobson moved this task from Needs Prioritization to Epics/Goals on the Web-Team-Backlog board.Apr 2 2019, 10:10 PM
xSavitar updated the task description. (Show Details)Apr 2 2019, 10:12 PM
gerritbot added a comment.May 3 2019, 8:48 PM

Change 499577 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] specials: Use MobileFrontend.Context service where need be

https://gerrit.wikimedia.org/r/499577

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.4; 2019-05-07).May 3 2019, 9:00 PM
xSavitar removed a project: Patch-For-Review.May 3 2019, 9:05 PM
xSavitar updated the task description. (Show Details)
gerritbot added a comment.May 5 2019, 10:47 PM

Change 508141 had a related patch set uploaded (by D3r1ck01; owner: Derick Alangi):
[mediawiki/extensions/MobileFrontend@master] Replace use of MobileContext::singleton() with MC service

https://gerrit.wikimedia.org/r/508141

gerritbot added a project: Patch-For-Review.May 5 2019, 10:47 PM
gerritbot added a comment.May 9 2019, 5:03 PM

Change 508141 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Replace use of MobileContext::singleton() with MC service

https://gerrit.wikimedia.org/r/508141

xSavitar removed a project: Patch-For-Review.May 9 2019, 5:04 PM
gerritbot added a comment.May 9 2019, 5:28 PM

Change 509124 had a related patch set uploaded (by D3r1ck01; owner: Derick Alangi):
[mediawiki/extensions/MobileFrontend@master] Follow-up on Iee53988dcd46f5b20fcd33ffbfe4177cf99c6893

https://gerrit.wikimedia.org/r/509124

gerritbot added a project: Patch-For-Review.May 9 2019, 5:28 PM
ReleaseTaggerBot edited projects, added MW-1.34-notes (1.34.0-wmf.5; 2019-05-14); removed MW-1.34-notes (1.34.0-wmf.4; 2019-05-07).May 9 2019, 6:00 PM
xSavitar moved this task from Doing [WIP] to Under Review on the User-xSavitar board.May 18 2019, 3:00 PM
gerritbot added a comment.Jul 18 2019, 10:13 PM

Change 509124 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Follow-up on Iee53988dcd: Use MobileContext service instead

https://gerrit.wikimedia.org/r/509124

Jdlrobson removed a project: Patch-For-Review.Jul 18 2019, 10:22 PM
ReleaseTaggerBot edited projects, added MW-1.34-notes (1.34.0-wmf.15; 2019-07-23); removed MW-1.34-notes (1.34.0-wmf.5; 2019-05-14).Jul 18 2019, 11:00 PM
xSavitar moved this task from Under Review to Doing [WIP] on the User-xSavitar board.Jul 22 2019, 10:17 AM
Jdlrobson moved this task from Backlog to Team: web on the MobileFrontend board.Jul 24 2020, 3:00 PM
Aklapper removed xSavitar as the assignee of this task.Jul 2 2021, 5:17 AM

Removing task assignee due to inactivity, as this open task has been assigned for more than two years (see emails sent to assignee on May26 and Jun17, and T270544). Please assign this task to yourself again if you still realistically [plan to] work on this task - it would be very welcome!

(See https://www.mediawiki.org/wiki/Bug_management/Assignee_cleanup for tips how to best manage your individual work in Phabricator.)

Jdlrobson moved this task from Epics/Goals to Tracking on the Web-Team-Backlog board.Jul 26 2021, 9:35 PM
Jdlrobson edited projects, added Web-Team-Backlog (Tracking); removed Web-Team-Backlog.
Jdlrobson edited projects, added Web-Team-Backlog (Needs Prioritization (Tech)); removed Web-Team-Backlog (Tracking).Sep 16 2021, 4:42 PM
Jdlrobson moved this task from Backlog to Simplify MobileFrontend on the Web-Team-Backlog (Needs Prioritization (Tech)) board.Sep 16 2021, 9:33 PM
Jdlrobson closed this task as Declined.Jul 21 2022, 11:45 PM

Closing this task since T143189 is not a focus right now. If that changes, we can consider reopening this.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits