Page MenuHomePhabricator
Create Task
Maniphest T218299

Check for edit conflicts in schema undo/restore/rollback(?)
Closed, ResolvedPublic
Actions

Details

SubjectRepoBranchLines +/-
Style the error message in restore a bit strongermediawiki/extensions/WikibaseSchemamaster+2 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

• Lucas_Werkmeister_WMDE created this task.Mar 14 2019, 2:34 PM
• Lucas_Werkmeister_WMDE moved this task from Backlog to Ready to pick up on the EntitySchema board.Mar 14 2019, 2:36 PM
Michael edited projects, added Shape Expressions Sprint 4; removed EntitySchema.Mar 18 2019, 1:19 PM
Michael claimed this task.Mar 20 2019, 10:07 AM
Michael moved this task from Backlog to Doing on the Shape Expressions Sprint 4 board.
Restricted Application added a project: User-Michael. · View Herald TranscriptMar 20 2019, 10:08 AM
gerritbot subscribed.Mar 20 2019, 11:50 AM

Change 497755 had a related patch set uploaded (by Michael Große; owner: Michael Große):
[mediawiki/extensions/WikibaseSchema@master] Style the error message in restore a bit stronger

https://gerrit.wikimedia.org/r/497755

gerritbot added a project: Patch-For-Review.Mar 20 2019, 11:50 AM
Michael added a comment.Mar 20 2019, 12:08 PM

There seems not much to do here:

  • Restore already checks for edit conflicts, the patch above makes the message actually look like an error
  • Undo just works. If there is a conflict it refuses, if not it patches the (new) base revision
Michael moved this task from 🗃️ Incoming to 💬 waiting on other's work or feedback on the User-Michael board.Mar 20 2019, 12:21 PM
Michael moved this task from Doing to Peer Review on the Shape Expressions Sprint 4 board.
Michael moved this task from Peer Review to Verification on the Shape Expressions Sprint 4 board.Mar 20 2019, 1:14 PM
gerritbot added a comment.Mar 20 2019, 1:20 PM

Change 497755 merged by jenkins-bot:
[mediawiki/extensions/WikibaseSchema@master] Style the error message in restore a bit stronger

https://gerrit.wikimedia.org/r/497755

Lea_Lacroix_WMDE subscribed.Mar 25 2019, 9:56 AM

What's the process to test it?

Lea_Lacroix_WMDE added a comment.Mar 25 2019, 9:59 AM

Tested by editing the content while being on the restore preview in another tab, it works as expected

Michael moved this task from 💬 waiting on other's work or feedback to ✅ my work done on the User-Michael board.Mar 25 2019, 12:09 PM
Lydia_Pintscher closed this task as Resolved.Mar 25 2019, 12:40 PM
Lydia_Pintscher moved this task from Verification to Done on the Shape Expressions Sprint 4 board.
• Lucas_Werkmeister_WMDE mentioned this in T219531: Check for internal edit conflicts in schema undo/restore.Mar 28 2019, 4:33 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL