Maniphest T219313

Prevent moving Schema pages
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Lucas_Werkmeister_WMDE
	Mar 26 2019, 6:34 PM

Description

Currently, it’s possible to move Schema pages, even between namespaces. I don’t think we want to allow this.

Details

	Subject	Repo	Branch	Lines +/-
	Declare EntitySchema namespace as not movable	mediawiki/extensions/EntitySchema	master	+2 -21
	Make Schema namespace immovable	mediawiki/extensions/WikibaseSchema	master	+20 -1

Customize query in gerrit

Related Objects

Mentioned In: T266280: ZObject namespace pages should not be movable
Mentioned Here: T218181: Properly handle (=disallow) imports

Event Timeline

Lucas_Werkmeister_WMDE created this task.Mar 26 2019, 6:34 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 26 2019, 6:34 PM

The first two patches of T218181: Properly handle (=disallow) imports should also prevent moving pages into or out of the Schema namespace, but I think that doesn’t solve the problem of moving them within the namespace.

Ufff yeah we want to disallow that before going to production.

Picking this up. I’m not sure when/if we want to estimate this; SHA2-256 commitment on my estimate: 3f113697dffedcbbe84cf59fc0e2ec8926697fb6451c5e89e90f7c16d633bb56

Lucas_Werkmeister_WMDE moved this task from Backlog to Doing on the Shape Expressions Sprint 5 board.Mar 27 2019, 1:28 PM

Lucas_Werkmeister_WMDE moved this task from Doing to Peer Review on the Shape Expressions Sprint 5 board.Mar 27 2019, 1:50 PM

Change 499481 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseSchema@master] Make Schema namespace immovable

https://gerrit.wikimedia.org/r/499481

gerritbot added a project: Patch-For-Review.Mar 27 2019, 1:50 PM

This patch doesn’t prevent moving of Schema talk pages, because we don’t prevent that for item, property or lexeme talk pages either. But perhaps we should?

Moving back to backlog (per the open question in T219313#5061925).

Change 499481 merged by jenkins-bot:
[mediawiki/extensions/WikibaseSchema@master] Make Schema namespace immovable

https://gerrit.wikimedia.org/r/499481

In T219313#5061925, @Lucas_Werkmeister_WMDE wrote:

This patch doesn’t prevent moving of Schema talk pages, because we don’t prevent that for item, property or lexeme talk pages either. But perhaps we should?

As we quickly discussed today: Let's leave the talk pages movable as with Items and co.

hoo moved this task from Backlog to Verification on the Shape Expressions Sprint 5 board.Mar 27 2019, 8:06 PM

\o/

Bugreporter mentioned this in T266280: ZObject namespace pages should not be movable.Oct 22 2020, 9:03 PM

Maintenance_bot removed a project: Patch-For-Review.Oct 22 2020, 9:10 PM

Change 713444 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/EntitySchema@master] Declare EntitySchema namespace as not movable

https://gerrit.wikimedia.org/r/713444

gerritbot added a project: Patch-For-Review.Aug 17 2021, 9:14 AM

Change 713444 merged by jenkins-bot: