Page MenuHomePhabricator

Prevent moving Schema pages
Closed, ResolvedPublic

Description

Currently, it’s possible to move Schema pages, even between namespaces. I don’t think we want to allow this.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 26 2019, 6:34 PM

The first two patches of T218181: Properly handle (=disallow) imports should also prevent moving pages into or out of the Schema namespace, but I think that doesn’t solve the problem of moving them within the namespace.

Lydia_Pintscher triaged this task as High priority.Mar 26 2019, 9:00 PM
Lydia_Pintscher added a subscriber: Lydia_Pintscher.

Ufff yeah we want to disallow that before going to production.

Picking this up. I’m not sure when/if we want to estimate this; SHA2-256 commitment on my estimate: 3f113697dffedcbbe84cf59fc0e2ec8926697fb6451c5e89e90f7c16d633bb56

Change 499481 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseSchema@master] Make Schema namespace immovable

https://gerrit.wikimedia.org/r/499481

This patch doesn’t prevent moving of Schema talk pages, because we don’t prevent that for item, property or lexeme talk pages either. But perhaps we should?

hoo added a subscriber: hoo.

Moving back to backlog (per the open question in T219313#5061925).

Change 499481 merged by jenkins-bot:
[mediawiki/extensions/WikibaseSchema@master] Make Schema namespace immovable

https://gerrit.wikimedia.org/r/499481

This patch doesn’t prevent moving of Schema talk pages, because we don’t prevent that for item, property or lexeme talk pages either. But perhaps we should?

As we quickly discussed today: Let's leave the talk pages movable as with Items and co.

Lydia_Pintscher closed this task as Resolved.Apr 1 2019, 9:10 AM
Lydia_Pintscher moved this task from Verification to Done on the Shape Expressions Sprint 5 board.

\o/