Somewhere on the way last couple of commits, the demos lost their ability for show widget code.
Uncaught ReferenceError: javascriptStringify is not defined
Somewhere on the way last couple of commits, the demos lost their ability for show widget code.
Uncaught ReferenceError: javascriptStringify is not defined
Change 501121 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[oojs/ui@master] Revert "build: Upgrade javascript-stringify to 2.0.0 for audit fix"
Change 501962 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[oojs/ui@master] [WIP] demos: Attempt to fix stringify by loading as a module
@kaldari Had the same thought. I can't care about the mid-term preferable solution brought up by @matmarex to build the demos on top of Webpack in time for the Hackathon. Not sure about @Jdforrester-WMF attempt above.
Change 501121 merged by jenkins-bot:
[oojs/ui@master] Revert "build: Upgrade javascript-stringify to 2.0.0 for audit fix"
Change 513020 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/core@master] Update OOUI to v0.32.0
@Volker_E: In T219479#5174020 a year ago you wrote "Stalled until next package update attempt." Does that refer to bumping javascript-stringify in package-lock.json and package.json from current "1.6.0" to a newer version? If so, is there a task for that?
(Or did that somehow refer to oojs-ui itself (as merged https://gerrit.wikimedia.org/r/513020 was linked to this task for reasons that I don't know)?)
Asking as there is no link to "the demos" in the task desc hence no idea where to re-test or see the actual bug. And as this task has been stalled for a year...
Yes.
If so, is there a task for that?
This is that task. Probably blocked by upstream. We're not interested in wasting countless more hours screwing around with this breakage.
Is this task the reason there are no code samples in the "Dialog" tab in the demos? (That's what I came to Phab to report, but I remembered to search first.)
If not, the other code samples (in the Widgets and Layouts tabs) are working for me, so I guess this could be closed then.
There have never been code samples in “Dialog” tab/view. This task is still awaiting a new javascript-stringify version that doesn't break the other tabs/views.