Page MenuHomePhabricator
Create Task
Maniphest T219819

Enable context detection in all languages
Closed, ResolvedPublic
Actions

Description

As part of the first deployment of ExternalGuidance we had enabled English as the only language where the context detection happens. This was done using the config variable ExternalGuidanceEnableContextDetection.

We discussed the current state and it was decided to remove this restriction. Technically just removing ExternalGuidanceEnableContextDetection from configuration will do since the default value is true

Details

SubjectRepoBranchLines +/-
Remove ExternalGuidanceEnableContextDetectionoperations/mediawiki-configmaster+0 -6
Redirect Google Translate any wiki source to mobileoperations/puppetproduction+5 -3
Customize query in gerrit

Event Timeline

santhosh created this task.Apr 1 2019, 5:37 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 1 2019, 5:37 PM
Pginer-WMF triaged this task as Medium priority.Apr 16 2019, 7:40 AM
gerritbot added a comment.Apr 16 2019, 7:51 AM

Change 504261 had a related patch set uploaded (by KartikMistry; owner: KartikMistry):
[operations/mediawiki-config@master] Remove ExternalGuidanceEnableContextDetection

https://gerrit.wikimedia.org/r/504261

gerritbot added a project: Patch-For-Review.Apr 16 2019, 7:51 AM
KartikMistry moved this task from Backlog to In Review on the ExternalGuidance board.Apr 16 2019, 7:53 AM
KartikMistry added a comment.Apr 16 2019, 10:43 AM

Depends on: https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/ExternalGuidance/+/497713/

gerritbot added a comment.Apr 24 2019, 5:01 AM

Change 506043 had a related patch set uploaded (by Santhosh; owner: Santhosh):
[operations/puppet@production] Redirect Google Translate any wiki source to mobile

https://gerrit.wikimedia.org/r/506043

gerritbot added a comment.Jun 6 2019, 10:40 AM

Change 506043 merged by Ema:
[operations/puppet@production] Redirect Google Translate any wiki source to mobile

https://gerrit.wikimedia.org/r/506043

santhosh added a comment.Jun 7 2019, 10:48 AM
In T219819#5239785, @gerritbot wrote:

Change 506043 merged by Ema:
[operations/puppet@production] Redirect Google Translate any wiki source to mobile

https://gerrit.wikimedia.org/r/506043

I can confirm that https://translate.google.com/translate?sl=auto&tl=en&u=https%3A%2F%2Fes.wikipedia.org%2Fwiki%2FMoon gives mobile site

gerritbot added a comment.Jun 20 2019, 11:14 AM

Change 504261 merged by jenkins-bot:
[operations/mediawiki-config@master] Remove ExternalGuidanceEnableContextDetection

https://gerrit.wikimedia.org/r/504261

Stashbot added a comment.Jun 20 2019, 11:20 AM

Mentioned in SAL (#wikimedia-operations) [2019-06-20T11:20:24Z] <kartik@deploy1001> Synchronized wmf-config/InitialiseSettings.php: SWAT [[gerrit:504261|Remove ExternalGuidanceEnableContentDetection]] (T219819) (duration: 01m 00s)

Maintenance_bot removed a project: Patch-For-Review.Jun 20 2019, 12:11 PM
santhosh moved this task from In Review to Done on the ExternalGuidance board.Jun 21 2019, 7:39 AM

As you can see non-English source languages also get ExternalGuidance features now:

image.png (531×1 px, 85 KB)

nshahquinn-wmf closed this task as Resolved.Apr 15 2020, 2:12 PM
nshahquinn-wmf subscribed.

Looks this is done.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits