Page MenuHomePhabricator

Suggestion for edit comments can appear without interaction
Closed, ResolvedPublic


Steps to reproduce:

  1. Edit a page in VE (on beta or somewhere else where the change for T50274 is available).
  2. Open the save dialog, enter a summary (using just one letter demonstrates the problem best).
  3. Continue editing.
  4. Open the save dialog again.

Actual result:
Suggestions are shown immediately, and they prevent you from accessing the checkboxes.

Expected result:
Suggestions should only be shown when I continue typing something in the summary field, like the native browser behaviour e.g. in OWE.

Yeah, there is a reason why my script has a hack around T169484.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 501558 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] EditSummaryWidget: Don't show suggestions on focus

Change 501558 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] EditSummaryWidget: Don't show suggestions on focus