Page MenuHomePhabricator

Editing timing data incorrect/meaningless when switching editor on mobile
Closed, ResolvedPublic

Description

When switching editors, we re-fire the ready and loaded events, with timing since the very first load (so potentially minutes). This data is not very helpful. If we want to measure the performance of switching we should use different event names.

edit: Looks like we just re-fire the loaded event, and ready is already correctly ignored.

Details

Related Gerrit Patches:
mediawiki/extensions/MobileFrontend : masterschemaEditAttemptStep: discard loaded events when switching modes

Event Timeline

Esanders created this task.Apr 11 2019, 1:43 PM
Restricted Application added a project: VisualEditor. · View Herald TranscriptApr 11 2019, 1:43 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Esanders updated the task description. (Show Details)Apr 11 2019, 1:49 PM
Esanders assigned this task to DLynch.Apr 11 2019, 1:55 PM
Esanders edited projects, added VisualEditor (Current work); removed VisualEditor.

It looks like the suppression of 'ready' events was implemented in
https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/MobileFrontend/+/479247/1/resources/mobile.editor.common/schemaEditAttemptStep.js
but it doesn't include loaded events.

Change 509088 had a related patch set uploaded (by DLynch; owner: DLynch):
[mediawiki/extensions/MobileFrontend@master] schemaEditAttemptStep: discard loaded events when switching modes

https://gerrit.wikimedia.org/r/509088

Change 509088 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] schemaEditAttemptStep: discard loaded events when switching modes

https://gerrit.wikimedia.org/r/509088

matmarex removed a project: Patch-For-Review.
matmarex added a subscriber: matmarex.
DLynch closed this task as Resolved.Jul 12 2019, 11:08 PM
DLynch added a project: Skipped QA.