Page MenuHomePhabricator
Create Task
Maniphest T221790

Parsoid extension API should use DOM fragments, not documents
Closed, ResolvedPublic
Actions

Description

All DOM building should really take place in a single document context; this simplifies handling the bag-on-the-side implementation and would allow a 1-to-1 mapping between env and doc.

In particular, the toDOM method in the extension API currently returns a DOMDocument; it should return a DOMFragment (owned by the env's main document) instead.

Details

SubjectRepoBranchLines +/-
Update Parsoid to 0.12.2mediawiki/vendorREL1_35+66 -125
Remove special case for the html extension when unpackingmediawiki/services/parsoidREL1_35+20 -45
Bump wikimedia/parsoid to 0.13.0-a12mediawiki/vendormaster+1 K -974
One document to rule them allmediawiki/services/parsoidmaster+720 -523
Bump wikimedia/parsoid to 0.13.0-a8mediawiki/vendormaster+517 -331
Remove special case for the html extension when unpackingmediawiki/services/parsoidmaster+20 -45
Customize query in gerrit

Related Objects
Search...

Event Timeline

cscott created this task.Apr 24 2019, 4:16 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 24 2019, 4:16 PM
Arlolra added a parent task: T179082: Use one ownerDocument for the entire parse.Apr 24 2019, 5:52 PM
• ssastry triaged this task as Medium priority.May 7 2019, 9:26 PM
• ssastry moved this task from Backlog to Post-Port Work on the Parsoid-PHP board.
• ssastry edited projects, added Parsoid; removed Parsoid-PHP.Dec 8 2019, 3:27 AM
• ssastry removed a subscriber: Parsing-Team--ARCHIVED.
• ssastry moved this task from Needs Triage to Tech Debt / Big changes on the Parsoid board.Jan 22 2020, 7:07 AM
Arlolra claimed this task.Jul 17 2020, 6:39 PM
gerritbot added a comment.Jul 29 2020, 11:06 PM

Change 617282 had a related patch set uploaded (by Arlolra; owner: Arlolra):
[mediawiki/services/parsoid@master] [WIP] One document to rule them all

https://gerrit.wikimedia.org/r/617282

gerritbot added a project: Patch-For-Review.Jul 29 2020, 11:06 PM
gerritbot added a comment.Aug 25 2020, 8:19 PM

Change 622425 had a related patch set uploaded (by Arlolra; owner: Arlolra):
[mediawiki/services/parsoid@master] Remove special case for the html extension

https://gerrit.wikimedia.org/r/622425

gerritbot added a comment.Aug 31 2020, 8:14 PM

Change 622425 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Remove special case for the html extension when unpacking

https://gerrit.wikimedia.org/r/622425

gerritbot added a comment.Sep 7 2020, 1:44 PM

Change 625641 had a related patch set uploaded (by Subramanya Sastry; owner: Subramanya Sastry):
[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.13.0-a8

https://gerrit.wikimedia.org/r/625641

gerritbot added a comment.Sep 7 2020, 3:57 PM

Change 625641 merged by jenkins-bot:
[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.13.0-a8

https://gerrit.wikimedia.org/r/625641

gerritbot added a comment.Sep 29 2020, 10:36 PM

Change 617282 merged by jenkins-bot:
[mediawiki/services/parsoid@master] One document to rule them all

https://gerrit.wikimedia.org/r/617282

Arlolra closed this task as Resolved.Sep 29 2020, 10:39 PM
Maintenance_bot removed a project: Patch-For-Review.Sep 29 2020, 11:11 PM
gerritbot added a comment.Oct 19 2020, 10:52 PM

Change 635100 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.13.0-a12

https://gerrit.wikimedia.org/r/635100

gerritbot added a project: Patch-For-Review.Oct 19 2020, 10:52 PM
gerritbot added a comment.Oct 20 2020, 1:28 AM

Change 635100 merged by jenkins-bot:
[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.13.0-a12

https://gerrit.wikimedia.org/r/635100

Maintenance_bot removed a project: Patch-For-Review.Oct 20 2020, 2:11 AM
gerritbot added a comment.Feb 8 2021, 4:43 PM

Change 662672 had a related patch set uploaded (by Paladox; owner: Arlolra):
[mediawiki/services/parsoid@REL1_35] Remove special case for the html extension when unpacking

https://gerrit.wikimedia.org/r/662672

gerritbot added a project: Patch-For-Review.Feb 8 2021, 4:43 PM
gerritbot added a comment.Mar 26 2021, 10:09 PM

Change 662672 merged by jenkins-bot:
[mediawiki/services/parsoid@REL1_35] Remove special case for the html extension when unpacking

https://gerrit.wikimedia.org/r/662672

gerritbot added a comment.Apr 8 2021, 5:48 PM

Change 677986 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/vendor@REL1_35] Update Parsoid to 0.12.2

https://gerrit.wikimedia.org/r/677986

gerritbot added a comment.Apr 8 2021, 6:10 PM

Change 677986 merged by C. Scott Ananian:

[mediawiki/vendor@REL1_35] Update Parsoid to 0.12.2

https://gerrit.wikimedia.org/r/677986

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits