Page MenuHomePhabricator

Structured Data table overflows when wikidata label is too long
Closed, ResolvedPublic

Description

Screenshot 2019-04-25 16.35.25.png (500×1 px, 110 KB)

Reproduction:

  1. set interface language as Polish
  2. go to https://commons.wikimedia.org/wiki/File:Cerkiew_bazylian%C3%B3w_Supra%C5%9Bl.jpg?uselang=pl
  3. click Structured Data tab

Event Timeline

@PDrouin-WMF I can't recall if we actually did finalize design rules for this. Ellipses after a certain character count?

Well, we're planning on having label text wrap for mobile, can we do the same here?

Well, we're planning on having label text wrap for mobile, can we do the same here?

I think so. I wonder how that'll work with RTL though. But wrap is how Wikidata does it currently.

RTL handling is up in the air regardless -- I'd rather us stay in keeping with Wikidata and wrap text than hide it.

Ramsey-WMF moved this task from Untriaged to Next up on the Multimedia board.

^ looks like word wrap it shall be :)

I'm pretty sure that some of the recent mobile-related patches we have merged on master will fix this once we deploy a new release.

Here's what I have in my local development environment, running the latest version of our extension (I set my interface language to Polish to approximate):

Screen Shot 2019-05-20 at 12.09.45 PM.png (684×1 px, 126 KB)

The long label text wraps, and no elements overflow outside of the container.

matthiasmullie subscribed.

Yes, should be fixed already. Moving to Needs QA for verification.

Actually, let's move this to "Verify on Production", since there's nothing new to test, and the example (and fix) are already in prod.

Tested on Production and confirmed to be working.