Maniphest T221975

Long captions are being displayed differently than short captions
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	• PDrouin-WMF
	Apr 26 2019, 4:41 PM

Description

User story: N/A

We have this:

Long captions are being handled in a different way than shorter ones, as you can see in this screenshot.

Screenshot 2019-04-26 12.28.54.png (462×1 px, 80 KB)

The language label being positioned on the line above the caption should only be applicable to smaller widths (i.e., mobile screens).

We want this:

Long captions should be handled on wider widths just the same as shorter captions. In the screenshot above, the long caption should start at the same position as the shorter one.

Acceptance Criteria:

Long captions should be handled the same as short captions.

QA Results

AC	Status	Details
1	✅	T221975#5801187
2	✅	T221975#5801187
3	✅	T221975#5801187
4	✅	T221975#5801187

QA Results - Production

AC	Status	Details
1	✅	T221975#5860609
2	✅	T221975#5860609
3	✅	T221975#5860609
4	✅	T221975#5860609

Details

	Subject	Repo	Branch	Lines +/-
	Ensure caption layout is consistent regardless of caption length	mediawiki/extensions/WikibaseMediaInfo	master	+2 -2

Customize query in gerrit

Event Timeline

• PDrouin-WMF created this task.Apr 26 2019, 4:41 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 26 2019, 4:41 PM

• Ramsey-WMF triaged this task as Medium priority.Apr 26 2019, 11:43 PM

• Ramsey-WMF added projects: Structured Data Engineering, Structured-Data-Team-Current-Work.

• Ramsey-WMF moved this task from Untriaged to Next up on the Multimedia board.

• Ramsey-WMF removed a project: Structured-Data-Team-Current-Work.Aug 8 2019, 6:02 PM

Aklapper edited projects, added Structured-Data-Backlog; removed Multimedia.Aug 10 2019, 11:54 PM

Restricted Application added a project: Multimedia. · View Herald TranscriptAug 10 2019, 11:54 PM

• Ramsey-WMF removed a project: Multimedia.Aug 14 2019, 8:27 PM

• Ramsey-WMF edited projects, added Structured-Data-Backlog (Current Work); removed Structured-Data-Backlog.Oct 16 2019, 2:05 AM

Change 562621 had a related patch set uploaded (by Anne Tomasevich; owner: Anne Tomasevich):
[mediawiki/extensions/WikibaseMediaInfo@master] Ensure caption layout is consistent regardless of caption length

https://gerrit.wikimedia.org/r/562621

gerritbot added a project: Patch-For-Review.Jan 7 2020, 9:46 PM

AnneT claimed this task.Jan 7 2020, 9:46 PM

Cparle moved this task from Incoming to Code Review on the Structured-Data-Backlog (Current Work) board.Jan 8 2020, 11:54 AM

Cparle moved this task from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.

Change 562621 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Ensure caption layout is consistent regardless of caption length

https://gerrit.wikimedia.org/r/562621

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.15; 2020-01-14).Jan 8 2020, 1:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jan 8 2020, 1:10 PM

• Ramsey-WMF reassigned this task from AnneT to Edtadros.Jan 9 2020, 8:04 PM

• Ramsey-WMF added a subscriber: AnneT.

Test Result

Status: ✅ PASS
OS: macOS Catalina
Browser: Chrome
Device: MBP
Emulated Device: iPhoneX

Test Artifact(s):

QA Steps: Long captions should be handled the same as short captions. Test in Beta, test short and long caption. Should test on both mobile and desktop. Test RTL as well.

✅ AC1: Mobile:

✅ AC2: Desktop:

✅ AC3: RTL Mobile:

✅ AC4: RTL Desktop:

Edtadros updated the task description. (Show Details)Jan 14 2020, 10:19 AM

• Ramsey-WMF moved this task from Needs QA to Verify on Production on the Structured-Data-Backlog (Current Work) board.Jan 22 2020, 7:44 PM

This is ready to be tested on production Commons.

Test Result - Prod