Page MenuHomePhabricator
Create Task
Maniphest T222182

Short URL doesn’t work on embed.html
Closed, ResolvedPublic5 Estimated Story Points
Actions

Details

SubjectRepoBranchLines +/-
Add URL shortener configuration to embed.htmlwikidata/query/guimaster+2 -1
Customize query in gerrit

Related Objects

Event Timeline

Lucas_Werkmeister_WMDE created this task.Apr 30 2019, 2:40 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 30 2019, 2:40 PM
Lucas_Werkmeister_WMDE added a comment.Apr 30 2019, 2:40 PM

Possibly the same underlying issue as T222129: WDQS link back to WDQS from a rendered result doesn't show the SPARQL used to create the report.

Lucas_Werkmeister_WMDE moved this task from Incoming to Ready to estimate on the Wikidata-Campsite board.Apr 30 2019, 2:41 PM
Lucas_Werkmeister_WMDE set the point value for this task to 5.Apr 30 2019, 2:48 PM
Lucas_Werkmeister_WMDE edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)); removed Wikidata-Campsite.
gerritbot added a comment.Apr 30 2019, 5:30 PM

Change 507383 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[wikidata/query/gui@master] Add URL shortener configuration to embed.html

https://gerrit.wikimedia.org/r/507383

gerritbot added a project: Patch-For-Review.Apr 30 2019, 5:30 PM
Lucas_Werkmeister_WMDE claimed this task.Apr 30 2019, 5:30 PM
Lucas_Werkmeister_WMDE moved this task from To Do (prioritised from top to bottom) to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
In T222182#5147195, @Lucas_Werkmeister_WMDE wrote:

Possibly the same underlying issue as T222129: WDQS link back to WDQS from a rendered result doesn't show the SPARQL used to create the report.

(Narrator: it was not the same underlying issue.)

Lucas_Werkmeister_WMDE mentioned this in rWDQGc5c25eae0965: Add URL shortener configuration to embed.html.Apr 30 2019, 5:33 PM
gerritbot added a comment.Apr 30 2019, 6:02 PM

Change 507383 merged by jenkins-bot:
[wikidata/query/gui@master] Add URL shortener configuration to embed.html

https://gerrit.wikimedia.org/r/507383

Lucas_Werkmeister_WMDE moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Apr 30 2019, 6:07 PM
Smalyshev triaged this task as Medium priority.Apr 30 2019, 7:32 PM
Stashbot mentioned this in T222133: "Edit SPARQL" link is broken in embed.html.Apr 30 2019, 7:35 PM
Stashbot mentioned this in T222129: WDQS link back to WDQS from a rendered result doesn't show the SPARQL used to create the report.
Stashbot mentioned this in T222181: “Edit visually” broken on embed.htm.

Mentioned in SAL (#wikimedia-operations) [2019-04-30T19:35:36Z] <smalyshev@deploy1001> Started deploy [wdqs/wdqs@4360316]: Redeploy GUI for fixes T222133, T222129, T222181, T222182

Stashbot added a comment.Apr 30 2019, 7:44 PM

Mentioned in SAL (#wikimedia-operations) [2019-04-30T19:44:53Z] <smalyshev@deploy1001> Finished deploy [wdqs/wdqs@4360316]: Redeploy GUI for fixes T222133, T222129, T222181, T222182 (duration: 09m 17s)

Lydia_Pintscher subscribed.May 1 2019, 10:15 AM

I tried it with this query and I get "URL shortening failed". Not sure if this is an independent issue or not.

Lydia_Pintscher moved this task from Test (Verification) to To Do (prioritised from top to bottom) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.May 1 2019, 10:15 AM
Jheald subscribed.May 1 2019, 11:02 AM

@Lydia_Pintscher : No, that's T220703 : Maximum length of a URL that can currently be shortened in 2,000 chars; yours was 2,561
Also T221126 (Better error reporting).

Lydia_Pintscher closed this task as Resolved.May 1 2019, 11:21 AM
Lydia_Pintscher moved this task from To Do (prioritised from top to bottom) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.

Ah great. Thanks :)

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL