Page MenuHomePhabricator
Create Task
Maniphest T222133

"Edit SPARQL" link is broken in embed.html
Closed, ResolvedPublic5 Estimated Story Points
Actions

Description

In the right-side toolbar in embed.html, the "Edit SPARQL" link (under "Edit visually" and above "Help") doesn't do anything.

Details

SubjectRepoBranchLines +/-
Merging from da512410d6f368cd8ba50c0482d9d818858a508c:wikidata/query/gui-deployproduction+1 -1
Don’t use _ as unused variable namewikidata/query/guimaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

Yair_rand created this task.Apr 30 2019, 5:05 AM
Restricted Application added a project: Wikidata. · View Herald TranscriptApr 30 2019, 5:05 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Lucas_Werkmeister_WMDE subscribed.Apr 30 2019, 10:29 AM

Probably the same underlying issue as T222129: WDQS link back to WDQS from a rendered result doesn't show the SPARQL used to create the report, and both caused by our config refactorings (T194179), but let’s not merge the tasks for now.

Lucas_Werkmeister_WMDE mentioned this in T194179: Allow configuring WDQS UI without changes to files under version control.Apr 30 2019, 10:29 AM
Lydia_Pintscher added a project: Wikidata-Campsite.Apr 30 2019, 10:38 AM
Lydia_Pintscher moved this task from Incoming to Ready to estimate on the Wikidata-Campsite board.
Lucas_Werkmeister_WMDE moved this task from Ready to estimate to Wikidata-Campsite-Iteration-∞ (On Hold) on the Wikidata-Campsite board.Apr 30 2019, 2:41 PM
Lucas_Werkmeister_WMDE edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)); removed Wikidata-Campsite.
Lucas_Werkmeister_WMDE set the point value for this task to 5.Apr 30 2019, 2:47 PM
gerritbot added a comment.Apr 30 2019, 5:23 PM

Change 507380 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[wikidata/query/gui@master] Don’t use _ as unused variable name

https://gerrit.wikimedia.org/r/507380

gerritbot added a project: Patch-For-Review.Apr 30 2019, 5:23 PM
Lucas_Werkmeister_WMDE claimed this task.Apr 30 2019, 5:23 PM
Lucas_Werkmeister_WMDE moved this task from To Do (prioritised from top to bottom) to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
hoo moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Apr 30 2019, 5:26 PM
gerritbot added a comment.Apr 30 2019, 5:27 PM

Change 507380 merged by jenkins-bot:
[wikidata/query/gui@master] Don’t use _ as unused variable name

https://gerrit.wikimedia.org/r/507380

Lucas_Werkmeister_WMDE mentioned this in rWDQGda512410d6f3: Don’t use _ as unused variable name.Apr 30 2019, 5:28 PM
gerritbot added a comment.Apr 30 2019, 5:30 PM

Change 507382 had a related patch set uploaded (by WDQSGuiBuilder; owner: WDQSGuiBuilder):
[wikidata/query/gui-deploy@production] Merging from da512410d6f368cd8ba50c0482d9d818858a508c:

https://gerrit.wikimedia.org/r/507382

gerritbot added a comment.Apr 30 2019, 6:27 PM

Change 507382 abandoned by Smalyshev:
Merging from da512410d6f368cd8ba50c0482d9d818858a508c:

Reason:
superceded

https://gerrit.wikimedia.org/r/507382

Smalyshev triaged this task as Medium priority.Apr 30 2019, 7:32 PM
Stashbot added a comment.Apr 30 2019, 7:35 PM

Mentioned in SAL (#wikimedia-operations) [2019-04-30T19:35:36Z] <smalyshev@deploy1001> Started deploy [wdqs/wdqs@4360316]: Redeploy GUI for fixes T222133, T222129, T222181, T222182

Stashbot mentioned this in T222129: WDQS link back to WDQS from a rendered result doesn't show the SPARQL used to create the report.Apr 30 2019, 7:35 PM
Stashbot mentioned this in T222181: “Edit visually” broken on embed.htm.
Stashbot mentioned this in T222182: Short URL doesn’t work on embed.html.
Stashbot added a comment.Apr 30 2019, 7:44 PM

Mentioned in SAL (#wikimedia-operations) [2019-04-30T19:44:53Z] <smalyshev@deploy1001> Finished deploy [wdqs/wdqs@4360316]: Redeploy GUI for fixes T222133, T222129, T222181, T222182 (duration: 09m 17s)

Lydia_Pintscher closed this task as Resolved.May 1 2019, 10:11 AM
Lydia_Pintscher moved this task from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Lydia_Pintscher subscribed.

\o/

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL