Page MenuHomePhabricator
Create Task
Maniphest T222181

“Edit visually” broken on embed.htm
Closed, ResolvedPublic5 Estimated Story Points
Actions

Details

SubjectRepoBranchLines +/-
Merging from 38def4fc17168e6b0a6739239f8b53c420b2d2f8:wikidata/query/gui-deployproduction+10 -10
Adjust z-index to not overlay dropdownwikidata/query/guimaster+1 -1
Merging from da512410d6f368cd8ba50c0482d9d818858a508c:wikidata/query/gui-deployproduction+1 -1
Don’t use _ as unused variable namewikidata/query/guimaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

Lucas_Werkmeister_WMDE created this task.Apr 30 2019, 2:39 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 30 2019, 2:39 PM
Lucas_Werkmeister_WMDE added a comment.Apr 30 2019, 2:40 PM

Possibly the same underlying issue as T222129: WDQS link back to WDQS from a rendered result doesn't show the SPARQL used to create the report.

Lucas_Werkmeister_WMDE moved this task from Incoming to Ready to estimate on the Wikidata-Campsite board.Apr 30 2019, 2:41 PM
Lucas_Werkmeister_WMDE edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)); removed Wikidata-Campsite.Apr 30 2019, 2:47 PM
Lucas_Werkmeister_WMDE set the point value for this task to 5.
gerritbot added a comment.Apr 30 2019, 5:23 PM

Change 507380 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[wikidata/query/gui@master] Don’t use _ as unused variable name

https://gerrit.wikimedia.org/r/507380

gerritbot added a project: Patch-For-Review.Apr 30 2019, 5:23 PM
Lucas_Werkmeister_WMDE claimed this task.Apr 30 2019, 5:24 PM
Lucas_Werkmeister_WMDE moved this task from To Do (prioritised from top to bottom) to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
hoo moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Apr 30 2019, 5:26 PM
gerritbot added a comment.Apr 30 2019, 5:27 PM

Change 507380 merged by jenkins-bot:
[wikidata/query/gui@master] Don’t use _ as unused variable name

https://gerrit.wikimedia.org/r/507380

Lucas_Werkmeister_WMDE mentioned this in rWDQGda512410d6f3: Don’t use _ as unused variable name.Apr 30 2019, 5:28 PM
gerritbot added a comment.Apr 30 2019, 5:30 PM

Change 507382 had a related patch set uploaded (by WDQSGuiBuilder; owner: WDQSGuiBuilder):
[wikidata/query/gui-deploy@production] Merging from da512410d6f368cd8ba50c0482d9d818858a508c:

https://gerrit.wikimedia.org/r/507382

gerritbot added a comment.Apr 30 2019, 6:27 PM

Change 507382 abandoned by Smalyshev:
Merging from da512410d6f368cd8ba50c0482d9d818858a508c:

Reason:
superceded

https://gerrit.wikimedia.org/r/507382

Smalyshev triaged this task as Medium priority.Apr 30 2019, 7:33 PM
Stashbot mentioned this in T222133: "Edit SPARQL" link is broken in embed.html.Apr 30 2019, 7:35 PM
Stashbot mentioned this in T222129: WDQS link back to WDQS from a rendered result doesn't show the SPARQL used to create the report.

Mentioned in SAL (#wikimedia-operations) [2019-04-30T19:35:36Z] <smalyshev@deploy1001> Started deploy [wdqs/wdqs@4360316]: Redeploy GUI for fixes T222133, T222129, T222181, T222182

Stashbot mentioned this in T222182: Short URL doesn’t work on embed.html.Apr 30 2019, 7:35 PM
Stashbot added a comment.Apr 30 2019, 7:44 PM

Mentioned in SAL (#wikimedia-operations) [2019-04-30T19:44:53Z] <smalyshev@deploy1001> Finished deploy [wdqs/wdqs@4360316]: Redeploy GUI for fixes T222133, T222129, T222181, T222182 (duration: 09m 17s)

Lydia_Pintscher moved this task from Test (Verification) to To Do (prioritised from top to bottom) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.May 1 2019, 10:12 AM
Lydia_Pintscher subscribed.

I just tried it with this query and it still only shows an empty popup for me :/

Lucas_Werkmeister_WMDE added a comment.May 2 2019, 9:07 AM

That query can’t be visually edited (same result on the non-embed page as well) because it uses named subqueries (WITH syntax), which SPARQL.js can’t parse (because they’re a nonstandard Blazegraph extension). Try it with a simpler query instead.

hoo moved this task from To Do (prioritised from top to bottom) to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.May 3 2019, 9:39 AM
Lea_Lacroix_WMDE subscribed.May 6 2019, 8:32 AM

[[ https://query.wikidata.org/embed.html#%23Goats%0ASELECT%20%3Fitem%20%3FitemLabel%20%0AWHERE%20%0A{%0A%20%20%3Fitem%20wdt%3AP31%20wd%3AQ2934.%0A%20%20SERVICE%20wikibase%3Alabel%20{%20bd%3AserviceParam%20wikibase%3Alanguage%20%22[AUTO_LANGUAGE]%2Cen%22.%20}%0A} | Tried with goats ]], the pop-up is back.

Lea_Lacroix_WMDE added a comment.May 6 2019, 8:35 AM

However, when I click on the value to change it, the menu opens under the pop-up and the menu, making it not usable :( (tested on Firefox)

Screenshot from 2019-05-06 10-33-32.png (475×603 px, 21 KB)

Lea_Lacroix_WMDE moved this task from Test (Verification) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.May 8 2019, 8:24 AM
Michael claimed this task.May 13 2019, 3:59 PM
Restricted Application added a project: User-Michael. · View Herald TranscriptMay 13 2019, 3:59 PM
Michael moved this task from 🗃️ Incoming to ⏳ In progress on the User-Michael board.May 13 2019, 4:34 PM
gerritbot added a comment.May 13 2019, 4:39 PM

Change 509889 had a related patch set uploaded (by Michael Große; owner: Michael Große):
[wikidata/query/gui@master] Adjust z-index to not overlay dropdown

https://gerrit.wikimedia.org/r/509889

Michael mentioned this in rWDQGdc26f9836da1: Adjust z-index to not overlay dropdown.May 13 2019, 4:39 PM
Michael moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.May 13 2019, 4:40 PM
Michael moved this task from ⏳ In progress to 💬 waiting on other's work or feedback on the User-Michael board.
Michael mentioned this in rWDQG38def4fc1716: Adjust z-index to not overlay dropdown.May 13 2019, 5:36 PM
gerritbot added a comment.May 13 2019, 5:47 PM

Change 509889 merged by jenkins-bot:
[wikidata/query/gui@master] Adjust z-index to not overlay dropdown

https://gerrit.wikimedia.org/r/509889

gerritbot added a comment.May 13 2019, 5:51 PM

Change 509902 had a related patch set uploaded (by WDQSGuiBuilder; owner: WDQSGuiBuilder):
[wikidata/query/gui-deploy@production] Merging from 38def4fc17168e6b0a6739239f8b53c420b2d2f8:

https://gerrit.wikimedia.org/r/509902

Lucas_Werkmeister_WMDE moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.May 13 2019, 5:54 PM
gerritbot added a comment.May 14 2019, 2:56 PM

Change 509902 merged by Smalyshev:
[wikidata/query/gui-deploy@production] Merging from 38def4fc17168e6b0a6739239f8b53c420b2d2f8:

https://gerrit.wikimedia.org/r/509902

Michael moved this task from 💬 waiting on other's work or feedback to ✅ my work done on the User-Michael board.May 16 2019, 11:24 AM
Lydia_Pintscher closed this task as Resolved.May 27 2019, 8:51 AM
Lydia_Pintscher moved this task from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.

\o/

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits