Page MenuHomePhabricator

Improve error handling and instrumentation logging for blocked users
Open, Needs TriagePublic

Description

If a blocked user will attempt to add a question, he will get a nothing-telling message, see screenshot:

I think help panel should not offer a way to write a message/do anything that leads to an edit if an user is blocked. I think the help panel should either be not displayed at all, or offer only the "self-help" section.

Originally reported in T222014#5147163, @kostajh told me to create a new task, so here it goes.

Event Timeline

Urbanecm created this task.Apr 30 2019, 4:27 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 30 2019, 4:27 PM

Okay, adding manually. Shouldn't a Herald rule do that? :-)

Relevant to help panel codebase too - actually, relevant to the whole extension.

Thx, @Urbanecm - I re-checked the messages that handle the messages from blocked users making edits on pages:

  • first, there will be a specific message as soon as Edit is clicked:

  • then, upon attempting to save an edit, the message will be:

T218839 is also related, and is being worked on, so I'm going to move this into our current sprint.

kostajh renamed this task from Improve error handling for blocked users to Improve error handling and instrumentation logging for blocked users.Aug 23 2019, 2:12 PM
kostajh claimed this task.
kostajh removed kostajh as the assignee of this task.
kostajh moved this task from Incoming to In Progress on the Growth-Team (Current Sprint) board.

Unassigning myself for now but plan to come back to this early next week -- if someone else wants to get to it before then, please do.

Business rules need to be copied over from T218839 description plus comments.

MMiller_WMF added a subscriber: MMiller_WMF.

Moving off sprint board in favor of Newcomer Tasks V1.0 tasks.

MMiller_WMF moved this task from Inbox to Upcoming Work on the Growth-Team board.Nov 13 2019, 7:46 AM
Urbanecm edited subscribers, added: Urbanecm_WMF; removed: Urbanecm.Aug 22 2020, 6:52 PM