Page MenuHomePhabricator
Create Task
Maniphest T222223

Use thumb.php for impact image thumbnails
Closed, ResolvedPublic
Actions

Description

Currently the images for the impact module are loaded via File->transform() with the File::RENDER_NOW flag; this results in in ~200 milliseconds spent in $this-file->repoExists() as curl requests are completed.

If we drop the File::RENDER_NOW flag, we can use the thumbnail generation script for the images. So instead of:

background-image: url(/mediawiki/images/docker/default/thumb/c/c0/Palmasdelmarplaya.JPG/59px-Palmasdelmarplaya.JPG);

we would have:

background-image: url(/mediawiki/thumb.php?f=Palmasdelmarplaya.JPG&width=59.751037344398);

and could save ~200 milliseconds per page request.

Details

SubjectRepoBranchLines +/-
Drop RENDER_NOW flag, use thumbnail script for impact imagesmediawiki/extensions/GrowthExperimentswmf/1.34.0-wmf.3+1 -2
Drop RENDER_NOW flag, use thumbnail script for impact imagesmediawiki/extensions/GrowthExperimentsmaster+1 -2
Customize query in gerrit

Related Objects

Event Timeline

kostajh created this task.Apr 30 2019, 8:23 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 30 2019, 8:23 PM
gerritbot added a comment.Apr 30 2019, 8:23 PM

Change 507320 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/extensions/GrowthExperiments@master] Drop RENDER_NOW flag, use thumbnail script for impact images

https://gerrit.wikimedia.org/r/507320

gerritbot added a project: Patch-For-Review.Apr 30 2019, 8:23 PM
kostajh moved this task from Incoming to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.Apr 30 2019, 8:23 PM
kostajh mentioned this in rEGREb614164721da: Drop RENDER_NOW flag, use thumbnail script for impact images.Apr 30 2019, 8:26 PM
kostajh mentioned this in rEGRE05d066912186: Drop RENDER_NOW flag, use thumbnail script for impact images.Apr 30 2019, 8:38 PM
gerritbot added a comment.May 1 2019, 12:37 PM

Change 507320 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Drop RENDER_NOW flag, use thumbnail script for impact images

https://gerrit.wikimedia.org/r/507320

SBisson moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.May 1 2019, 12:38 PM
ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.4; 2019-05-07).May 1 2019, 2:01 PM
gerritbot added a comment.May 1 2019, 10:24 PM

Change 507713 had a related patch set uploaded (by Catrope; owner: Kosta Harlan):
[mediawiki/extensions/GrowthExperiments@wmf/1.34.0-wmf.3] Drop RENDER_NOW flag, use thumbnail script for impact images

https://gerrit.wikimedia.org/r/507713

• Catrope mentioned this in rEGREe5a23c648e43: Drop RENDER_NOW flag, use thumbnail script for impact images.May 1 2019, 10:25 PM
gerritbot added a comment.May 1 2019, 11:21 PM

Change 507713 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@wmf/1.34.0-wmf.3] Drop RENDER_NOW flag, use thumbnail script for impact images

https://gerrit.wikimedia.org/r/507713

Stashbot added a comment.May 1 2019, 11:34 PM

Mentioned in SAL (#wikimedia-operations) [2019-05-01T23:34:59Z] <catrope@deploy1001> Synchronized php-1.34.0-wmf.3/extensions/GrowthExperiments/: Drop RENDER_NOW for impact module images (T222223) (duration: 01m 04s)

ReleaseTaggerBot edited projects, added MW-1.34-notes (1.34.0-wmf.3; 2019-04-30); removed MW-1.34-notes (1.34.0-wmf.4; 2019-05-07).May 2 2019, 12:00 AM
Etonkovidova closed this task as Resolved.May 2 2019, 2:56 AM
Etonkovidova subscribed.

Example from 1Zhttps://test.wikipedia.org/wiki/Special:Impact/Zilant17

<a class="article-image" href="/wiki/Plants_in_space" title="Go to article" data-link-id="impact-article-image"><div alt="Plants in space" title="Plants in space" class="real-image" style="background-image: url(//upload.wikimedia.org/wikipedia/commons/thumb/b/ba/ISS-38_Young_sunflower_plant.jpg/60px-ISS-38_Young_sunflower_plant.jpg);"></div></a>


background-image: url(//upload.wikimedia.org/wikipedia/commons/thumb/b/ba/ISS-38_Young_sunflower_plant.jpg/60px-ISS-38_Young_sunflower_plant.jpg);
Aklapper removed a project: GrowthExperiments.Sep 11 2019, 12:47 PM
Maintenance_bot removed a project: Patch-For-Review.Sep 11 2019, 1:12 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits