In TemplateData param editor, typing a name equal to alias definitely disable Done button
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Pols12
	May 5 2019, 5:07 PM

Description

Edit TemplateData with dedicated editor
Edit a parameter in order to switch name and alias
Replace name field content with alias field content
A warning prompt (Error found. The chosen name is already in use by another parameter.) is displayed and Done button is disabled.
Change alias field content.
The warning message disappears.

Actually: Done button stays disabled.

Expected: since there is no more error, Done button should be available again.

Workaround: fake edit name field content adding a character then removing it.

Details

	Subject	Repo	Branch	Lines +/-
	tdDialog: handle name/alias swaps	mediawiki/extensions/TemplateData	master	+9 -1

Customize query in gerrit

Related Objects

Mentioned Here: T224137: In TemplateData param editor, assigning an alias that's the same as the name doesn't cause an error

Event Timeline

Pols12 created this task.May 5 2019, 5:07 PM

Restricted Application added a project: VisualEditor. · View Herald TranscriptMay 5 2019, 5:07 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

• marcella edited projects, added VisualEditor (Current work); removed VisualEditor.May 6 2019, 3:07 PM

Change 508861 had a related patch set uploaded (by DLynch; owner: DLynch):
[mediawiki/extensions/TemplateData@master] tdDialog: handle name/alias swaps

https://gerrit.wikimedia.org/r/508861

gerritbot added a project: Patch-For-Review.May 8 2019, 4:11 PM

DLynch claimed this task.May 8 2019, 4:11 PM

DLynch moved this task from Incoming to Code review on the VisualEditor (Current work) board.

Change 508861 merged by jenkins-bot:
[mediawiki/extensions/TemplateData@master] tdDialog: handle name/alias swaps

https://gerrit.wikimedia.org/r/508861

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.5; 2019-05-14).May 9 2019, 4:00 PM

DLynch moved this task from Code review to QA on the VisualEditor (Current work) board.May 9 2019, 4:48 PM

Ladsgroup removed a project: Patch-For-Review.May 22 2019, 9:17 AM

Seems OK on test2.wp

However, we can now define an alias identical to name, typing alias after having typed name field. Whereas it’s still impossible to type a name identical to alias when the alias has already been typed.

@Pols12: It's true that you can do this, but that was already the case before this patch, so "can now" doesn't seem accurate. Separate bug, I'd say. I've filed it as T224137.

matmarex added a project: Editing QA.Jun 12 2019, 4:11 PM

matmarex moved this task from Inbox to Low Priority on the Editing QA board.Jun 12 2019, 4:12 PM

• marcella moved this task from QA to Product owner review on the VisualEditor (Current work) board.Jul 24 2019, 5:12 PM

• marcella edited projects, added Skipped QA; removed Editing QA.

ppelberg closed this task as Resolved.Sep 2 2019, 11:46 PM

In TemplateData param editor, typing a name equal to alias definitely disable Done button Closed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

In TemplateData param editor, typing a name equal to alias definitely disable Done button
Closed, ResolvedPublic
Actions