Page MenuHomePhabricator
Create Task
Maniphest T222886

Disable interactive elements while saving
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

Mock

7.0 Termbox publish edit.png (675×383 px, 41 KB)

Acceptance Criteria

  • Once users click on the save button when being in edit mode, all interactive elements (all input fields, save, cancel button) become non-interactive. This means, that they cannot be focussed and changed.
  • Everything is overlayed with a layer that is 50% white
  • If the save failed or succeeded, all interactive elements are enabled again and the overlay disappears.

Details

SubjectRepoBranchLines +/-
Update Termboxmediawiki/extensions/Wikibasemaster+1 -1
Show an overlay while saving an editwikibase/termboxmaster+37 -2
Introduce generic overlay componentwikibase/termboxmaster+105 -46
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT219886 Unhappy Editing Paths
 ResolvedJakob_WMDET222886 Disable interactive elements while saving

Event Timeline

• Lea_WMDE created this task.May 9 2019, 1:53 PM
• Lea_WMDE updated the task description. (Show Details)May 23 2019, 1:57 PM
• Lea_WMDE merged a task: T222627: Handle situations of high latency between client and server.May 27 2019, 1:28 PM
• Lea_WMDE edited parent tasks, added: T219886: Unhappy Editing Paths; removed: T222627: Handle situations of high latency between client and server.
• Lea_WMDE updated the task description. (Show Details)May 29 2019, 12:56 PM
• Lea_WMDE moved this task from Backlog to MVP tickets: In preparation on the Wikidata-Termbox board.
• Lea_WMDE updated the task description. (Show Details)May 29 2019, 2:23 PM
• Lea_WMDE set the point value for this task to 3.
• Lea_WMDE moved this task from MVP tickets: In preparation to MVP things: Ready for pickup on the Wikidata-Termbox board.
• Lea_WMDE added a subscriber: • Hanna_Petruschat_WMDE.
• Hanna_Petruschat_WMDE added a comment.May 31 2019, 8:24 AM

I "messed up" with the IP overlay, not being aware that every other overlay in the Wikiworld works with 50% white and not with 25% black as I initially specified. So we might want to adapt to the white version here and make this small change in the IP and license overlay as well. I post it as a comment an will raise this question in the next team meeting (daily or sprint start?).

• Lea_WMDE updated the task description. (Show Details)Jun 3 2019, 10:21 AM
• Hanna_Petruschat_WMDE updated the task description. (Show Details)Jun 4 2019, 9:03 AM
Jakob_WMDE edited projects, added Wikidata-Termbox-Iteration-19; removed Wikidata-Termbox.Jul 8 2019, 9:33 AM
Jakob_WMDE claimed this task.Jul 8 2019, 9:39 AM
Jakob_WMDE moved this task from To Do to Doing on the Wikidata-Termbox-Iteration-19 board.
gerritbot added a comment.Jul 8 2019, 12:00 PM

Change 521259 had a related patch set uploaded (by Jakob; owner: Jakob):
[wikibase/termbox@master] Introduce generic overlay component

https://gerrit.wikimedia.org/r/521259

gerritbot added a project: Patch-For-Review.Jul 8 2019, 12:00 PM
gerritbot added a comment.Jul 8 2019, 1:50 PM

Change 521280 had a related patch set uploaded (by Jakob; owner: Jakob):
[wikibase/termbox@master] Show an overlay while saving an edit

https://gerrit.wikimedia.org/r/521280

Jakob_WMDE moved this task from Doing to Peer Review on the Wikidata-Termbox-Iteration-19 board.Jul 8 2019, 2:16 PM
gerritbot added a comment.Jul 8 2019, 3:31 PM

Change 521259 merged by jenkins-bot:
[wikibase/termbox@master] Introduce generic overlay component

https://gerrit.wikimedia.org/r/521259

Jakob_WMDE mentioned this in rWBTBe06255e86e11: Introduce generic overlay component.Jul 8 2019, 3:32 PM
gerritbot added a comment.Jul 8 2019, 3:36 PM

Change 521280 merged by jenkins-bot:
[wikibase/termbox@master] Show an overlay while saving an edit

https://gerrit.wikimedia.org/r/521280

Jakob_WMDE mentioned this in rWBTBab620d2864c5: Show an overlay while saving an edit.Jul 8 2019, 3:37 PM
Maintenance_bot removed a project: Patch-For-Review.Jul 8 2019, 4:10 PM
Tarrow moved this task from Peer Review to Done on the Wikidata-Termbox-Iteration-19 board.Jul 9 2019, 8:37 AM
gerritbot added a comment.Jul 9 2019, 8:42 AM

Change 521433 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/Wikibase@master] Update Termbox

https://gerrit.wikimedia.org/r/521433

gerritbot added a project: Patch-For-Review.Jul 9 2019, 8:42 AM
Jakob_WMDE moved this task from Done to Peer Review on the Wikidata-Termbox-Iteration-19 board.Jul 9 2019, 9:28 AM
gerritbot added a comment.Jul 9 2019, 9:50 AM

Change 521433 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Update Termbox

https://gerrit.wikimedia.org/r/521433

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.13; 2019-07-09).Jul 9 2019, 10:00 AM
Maintenance_bot removed a project: Patch-For-Review.Jul 9 2019, 10:10 AM
Jakob_WMDE moved this task from Peer Review to Test (Product Review) on the Wikidata-Termbox-Iteration-19 board.Jul 9 2019, 10:14 AM

This can now be product reviewed here: https://wikidata.beta.wmflabs.org/wiki/Q11?useformat=mobile

• Hanna_Petruschat_WMDE added a comment.Jul 15 2019, 7:21 AM

Thanks! Is there a way to produce a failed publish action? @Tarrow (as Jakob is not available)

Tarrow added a comment.Jul 15 2019, 8:28 AM

@Hanna_Petruschat_WMDE On beta? I guess the easiest thing to do is probably:

  1. Open a beta item on mobile and start editing.
  2. (In chrome) Right click -> 'Inspect'
  3. Select the 'Network' tab
  4. Check 'offline' box
  5. Try and save the edit
Tarrow added a project: Wikibase-Termbox-Iteration-20.Jul 15 2019, 8:38 AM
Tarrow moved this task from To Do to Test (Product Review) on the Wikibase-Termbox-Iteration-20 board.
• Hanna_Petruschat_WMDE closed this task as Resolved.Jul 15 2019, 3:44 PM
• Hanna_Petruschat_WMDE moved this task from Test (Product Review) to Done on the Wikibase-Termbox-Iteration-20 board.

Tested. Looks fine! Now really looking forward for the error message.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits