Page MenuHomePhabricator

Adding qualifiers results in the wrong button being focused
Open, NormalPublicBug

Description

User story: N/A

We have this:
Tested on Beta. When I add a qualifier to an item, the "Add qualifier" button is focused. Besides being confusing, this seems like an accessibility issue as well as.

We want this:
For the "Add qualifier" button to not be focused. Instead, automatically focus on the Property dropdown menu so users know what to do next: select a property.

GIF (tap to play):

Url to test on beta: https://commons.wikimedia.beta.wmflabs.org/wiki/File:Title_0.9209196250626945.png

Acceptance Criteria:

  • When adding a qualifier, the focus should be on "Property" dropdown, not "Add qualifier" button

QA Results

ACStatusDetails
1T223916#5293510

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 20 2019, 3:25 PM
PDrouin-WMF updated the task description. (Show Details)May 20 2019, 3:29 PM
Ramsey-WMF triaged this task as Normal priority.
Ramsey-WMF moved this task from Untriaged to Next up on the Multimedia board.

Change 511684 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/WikibaseMediaInfo@master] Focus dropdown when clicking button to add new qualifier

https://gerrit.wikimedia.org/r/511684

Change 511684 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Focus dropdown when clicking button to add new qualifier

https://gerrit.wikimedia.org/r/511684

Cparle updated the task description. (Show Details)

@matthiasmullie This bug was fixed, but has returned in the latest patch that's up on Beta. Could you take a look? Thanks! 😺

Change 516461 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/WikibaseMediaInfo@master] Focus property when adding new property

https://gerrit.wikimedia.org/r/516461

Oops! I messed up the order of add/focus operations, causing focus to stop working. Patch up, will be fixed shortly!

Change 516461 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Focus property when adding new property

https://gerrit.wikimedia.org/r/516461

Cparle reassigned this task from matthiasmullie to Edtadros.Jun 12 2019, 4:53 PM
Cparle added a subscriber: matthiasmullie.

Change 518000 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/WikibaseMediaInfo@wmf/1.34.0-wmf.8] Focus property when adding new property

https://gerrit.wikimedia.org/r/518000

Change 518000 merged by Matthias Mullie:
[mediawiki/extensions/WikibaseMediaInfo@wmf/1.34.0-wmf.8] Focus property when adding new property

https://gerrit.wikimedia.org/r/518000

Edtadros reassigned this task from Edtadros to Ramsey-WMF.Sat, Jun 29, 12:34 AM
Edtadros added a subscriber: Edtadros.

Test Result

Status: ✅ PASS
OS: macOS Mojave
Browser: Chrome
Device: MBP

Test Artifact(s):

Acceptance Criteria:

✅ AC1: When adding a qualifier, the focus should be on "Property" dropdown, not "Add qualifier" button

Edtadros updated the task description. (Show Details)Sat, Jun 29, 12:34 AM