Page MenuHomePhabricator

Type-hint all onLoadExtensionSchemaUpdate hook handler $updater parameter with DatabaseUpdater type
Closed, ResolvedPublic

Description

Per https://www.mediawiki.org/wiki/Manual:Hooks/LoadExtensionSchemaUpdates documentation, and code search: https://codesearch.wmflabs.org/deployed/?q=onLoadExtensionSchemaUpdates%5C(%20%5C%24&i=nope&files=&repos=, the idea here is to type hint all WMF deployed repos hook handler function $updater parameter with DatabaseUpdater

See example patch: https://gerrit.wikimedia.org/r/#/c/511602/


All extensions with unknown name of hook functions
https://codesearch.wmflabs.org/search/?q=function%5Cs%2B%5Cw%2B%5Cs*%5C(%20%5C%24updater&i=nope&files=&repos=

Remove also = null and return true for such hook functions

Event Timeline

Change 511602 had a related patch set uploaded (by D3r1ck01; owner: Derick Alangi):
[mediawiki/extensions/LiquidThreads@master] classes: Type hint $updater parameter in onLoadExtensionSchemaUpdates

https://gerrit.wikimedia.org/r/511602

Change 511602 merged by jenkins-bot:
[mediawiki/extensions/LiquidThreads@master] classes: Type hint $updater parameter in onLoadExtensionSchemaUpdates

https://gerrit.wikimedia.org/r/511602

Change 552681 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/extensions/PageTriage@master] Type hint $updater parameter in onLoadExtensionSchemaUpdates

https://gerrit.wikimedia.org/r/552681

Change 552682 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/extensions/SecurePoll@master] Classes: Type hint $updater parameter in onLoadExtensionSchemaUpdates

https://gerrit.wikimedia.org/r/552682

Change 552687 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/extensions/Math@master] Classes: Type hint $updater parameter in onLoadExtensionSchemaUpdates

https://gerrit.wikimedia.org/r/552687

Change 552688 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/extensions/LdapAuthentication@master] Classes: Type hint $updater parameter in onLoadExtensionSchemaUpdates

https://gerrit.wikimedia.org/r/552688

Change 552689 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/extensions/GlobalUsage@master] Classes: Type hint $updater parameter in onLoadExtensionSchemaUpdates

https://gerrit.wikimedia.org/r/552689

Change 552688 merged by jenkins-bot:
[mediawiki/extensions/LdapAuthentication@master] Classes: Type hint $updater parameter in onLoadExtensionSchemaUpdates

https://gerrit.wikimedia.org/r/552688

Change 552689 merged by jenkins-bot:
[mediawiki/extensions/GlobalUsage@master] Classes: Type hint $updater parameter in onLoadExtensionSchemaUpdates

https://gerrit.wikimedia.org/r/552689

Change 552682 merged by jenkins-bot:
[mediawiki/extensions/SecurePoll@master] Classes: Type hint $updater parameter in onLoadExtensionSchemaUpdates

https://gerrit.wikimedia.org/r/552682

Change 552687 merged by jenkins-bot:
[mediawiki/extensions/Math@master] Classes: Type hint $updater parameter in onLoadExtensionSchemaUpdates

https://gerrit.wikimedia.org/r/552687

Change 553235 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/extensions/WikiLove@master] Classes: Type hint $updater parameter in onLoadExtensionSchemaUpdates

https://gerrit.wikimedia.org/r/553235

Change 553238 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/extensions/CodeReview@master] Classes: Type hint $updater parameter in onLoadExtensionSchemaUpdates

https://gerrit.wikimedia.org/r/553238

Change 553238 merged by jenkins-bot:
[mediawiki/extensions/CodeReview@master] Classes: Type hint $updater parameter in onLoadExtensionSchemaUpdates

https://gerrit.wikimedia.org/r/553238

Change 552681 merged by jenkins-bot:
[mediawiki/extensions/PageTriage@master] Type hint $updater parameter in onLoadExtensionSchemaUpdates

https://gerrit.wikimedia.org/r/552681

Change 553235 merged by jenkins-bot:
[mediawiki/extensions/WikiLove@master] Classes: Type hint $updater parameter in onLoadExtensionSchemaUpdates

https://gerrit.wikimedia.org/r/553235

Ammarpad claimed this task.
Ammarpad removed a project: Patch-For-Review.