Page MenuHomePhabricator

Add a wiki-specific class to interwiki link
Closed, DeclinedPublic

Description

Currently the interwiki links are assigned the extiw CSS class regardless of the site they refers to. This class can be used, for instance, to assign a custom icon to the links, but there is no way to discern one wiki from the other.

I propose to add an additional CSS class with a name derived from the iw_prefix field in interwiki table obtained with the method LinkTarget->getInterwiki()

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 21 2019, 9:40 PM

Change 511782 had a related patch set uploaded (by Luca Mauri; owner: Luca Mauri):
[mediawiki/core@master] Add a wiki-specific class to interwiki link

https://gerrit.wikimedia.org/r/511782

Change 511782 abandoned by Krinkle:
Add a wiki-specific class to interwiki link

Reason:
Thanks Luca

https://gerrit.wikimedia.org/r/511782

Krinkle added a subscriber: Krinkle.Jul 9 2019, 5:15 PM

Meanwhile, in Gerrit Code Review…

Luca Mauri wrote (Patch Set 2):

I'm not sure additional complexity to the LinkRenderer and CSS API is needed for this feature request.

This I am not sure as well. If you can point me to additional resource for me to investigate on the matter, I will surely do so.

I believe the feature request could be accomplished with standard CSS attribute selectors. [..]
See for examples https://developer.mozilla.org/en-US/docs/Web/CSS/Attribute_selectors

Thanks for pointing this method out: this is a viable alternative should this proposal be rejected

Krinkle closed this task as Declined.Jul 9 2019, 5:15 PM

Change 511782 abandoned by Krinkle:
Add a wiki-specific class to interwiki link
Reason:
Thanks Luca
https://gerrit.wikimedia.org/r/511782

I am sorry this was rejected, but I still learnt something useful from this proposal, so thanks to you @Krinkle