Page MenuHomePhabricator
Create Task
Maniphest T224064

Add a wiki-specific class to interwiki link
Closed, DeclinedPublic
Actions

Description

Currently the interwiki links are assigned the extiw CSS class regardless of the site they refers to. This class can be used, for instance, to assign a custom icon to the links, but there is no way to discern one wiki from the other.

I propose to add an additional CSS class with a name derived from the iw_prefix field in interwiki table obtained with the method LinkTarget->getInterwiki()

Details

SubjectRepoBranchLines +/-
Add a wiki-specific class to interwiki linkmediawiki/coremaster+1 -0
Customize query in gerrit

Event Timeline

lucamauri created this task.May 21 2019, 9:40 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 21 2019, 9:40 PM
gerritbot added a comment.May 21 2019, 9:43 PM

Change 511782 had a related patch set uploaded (by Luca Mauri; owner: Luca Mauri):
[mediawiki/core@master] Add a wiki-specific class to interwiki link

https://gerrit.wikimedia.org/r/511782

gerritbot added a project: Patch-For-Review.May 21 2019, 9:43 PM
Krinkle edited projects, added Platform Engineering, MediaWiki-Interwiki; removed Wikimedia-Interwiki-links.May 21 2019, 9:52 PM
Jdforrester-WMF added a project: Parsing-Team--ARCHIVED.May 22 2019, 3:06 PM
CCicalese_WMF edited projects, added Platform Team Legacy (Watching / External); removed Platform Engineering.May 28 2019, 12:38 PM
gerritbot added a comment.Jul 9 2019, 5:13 PM

Change 511782 abandoned by Krinkle:
Add a wiki-specific class to interwiki link

Reason:
Thanks Luca

https://gerrit.wikimedia.org/r/511782

Krinkle subscribed.Jul 9 2019, 5:15 PM

Meanwhile, in Gerrit Code Review…

Luca Mauri wrote (Patch Set 2):

I'm not sure additional complexity to the LinkRenderer and CSS API is needed for this feature request.

This I am not sure as well. If you can point me to additional resource for me to investigate on the matter, I will surely do so.

I believe the feature request could be accomplished with standard CSS attribute selectors. [..]
See for examples https://developer.mozilla.org/en-US/docs/Web/CSS/Attribute_selectors

Thanks for pointing this method out: this is a viable alternative should this proposal be rejected

Krinkle closed this task as Declined.Jul 9 2019, 5:15 PM
Maintenance_bot removed a project: Patch-For-Review.Jul 9 2019, 6:10 PM
lucamauri added a comment.Jul 13 2019, 5:04 PM
In T224064#5318013, @gerritbot wrote:

Change 511782 abandoned by Krinkle:
Add a wiki-specific class to interwiki link

Reason:
Thanks Luca

https://gerrit.wikimedia.org/r/511782

I am sorry this was rejected, but I still learnt something useful from this proposal, so thanks to you @Krinkle

Quiddity subscribed.Oct 31 2019, 8:35 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits