Call to undefined method CommentStore::getCommentInternal
Closed, DuplicatePublicPRODUCTION ERROR
Actions

Assigned To

None

Authored By

	Tgr
	May 28 2019, 4:12 PM

Description

About 200/minute, for 10 minutes, around 2019-05-28 14:00 UTC (dashboard).

PHP Fatal Error: Uncaught Error: Call to undefined method CommentStore::getCommentInternal() in /srv/mediawiki/php-1.34.0-wmf.6/includes/CommentStore.php:448
Stack trace:
#0 /srv/mediawiki/php-1.34.0-wmf.6/includes/Revision/RevisionStore.php(1808): CommentStore->getCommentLegacy(Wikimedia\Rdbms\DBConnRef, string, stdClass, boolean)
#1 /srv/mediawiki/php-1.34.0-wmf.6/includes/Revision/RevisionStore.php(2167): MediaWiki\Revision\RevisionStore->newRevisionFromRow(stdClass, integer, Title)
#2 /srv/mediawiki/php-1.34.0-wmf.6/includes/Revision/RevisionStore.php(1535): MediaWiki\Revision\RevisionStore->loadRevisionFromConds(Wikimedia\Rdbms\DBConnRef, array, integer, Title)
#3 /srv/mediawiki/php-1.34.0-wmf.6/includes/Revision.php(138): MediaWiki\Revision\RevisionStore->getRevisionByTitle(Title, integer, integer)
#4 /srv/mediawiki/php-1.34.0-wmf.6/includes/actions/RawAction.php(190): Revision::newFromTitle(Title, integer)
#5 /srv/mediawiki/php-1.34.0-wmf.6/includes/actions/RawAction.php(159): RawAction->getRawText()
#6 /srv/mediawiki/php-1.34.0-wmf.6/includes/actions/FormlessAction.php(43): RawAction->onView()
#7 /srv/mediawiki/php-1.34.0-wmf.6/includes/MediaWiki.php(499): FormlessAction->show()
#8 /srv/mediawiki/php-1.34.0-wmf.6/includes/MediaWiki.php(294): MediaWiki->performAction(Article, Title)
#9 /srv/mediawiki/php-1.34.0-wmf.6/includes/MediaWiki.php(865): MediaWiki->performRequest()
#10 /srv/mediawiki/php-1.34.0-wmf.6/includes/MediaWiki.php(515): MediaWiki->main()
#11 /srv/mediawiki/php-1.34.0-wmf.6/index.php(42): MediaWiki->run()
#12 /srv/mediawiki/w/index.php(3): require(string)
#13 {main}

From the timing it seems like a train deploy byproduct, but went on pretty long for that, and affected group2 wikis.
(Also, the stack trace is cut off in PHP 7.2. Is that a known issue?)

Related Objects

Mentioned In: T224491: PHP 7 corruption during deployment (was: PHP 7 fatals on mw1262)
T220732: 1.34.0-wmf.7 deployment blockers

Event Timeline

Tgr created this task.May 28 2019, 4:12 PM

Restricted Application added a project: Social-Tools. · View Herald TranscriptMay 28 2019, 4:12 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Tgr edited projects, added MediaWiki-Comment-store; removed MediaWiki-extensions-Comments, Social-Tools.May 28 2019, 4:13 PM

CommentStore::getCommentInternal does exist, and wasn't added recently either, so I can't really imagine how this happened.

Tgr mentioned this in T220732: 1.34.0-wmf.7 deployment blockers.May 28 2019, 4:17 PM

RazeSoldier subscribed.May 28 2019, 4:23 PM

Krinkle closed this task as a duplicate of T224491: PHP 7 corruption during deployment (was: PHP 7 fatals on mw1262).May 28 2019, 4:44 PM

Krinkle mentioned this in T224491: PHP 7 corruption during deployment (was: PHP 7 fatals on mw1262).May 28 2019, 4:46 PM

• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:06 PM

Call to undefined method CommentStore::getCommentInternalClosed, DuplicatePublicPRODUCTION ERRORActions

Description

Related Objects

Event Timeline

Call to undefined method CommentStore::getCommentInternal
Closed, DuplicatePublicPRODUCTION ERROR
Actions