Page MenuHomePhabricator

Editing entity schemas pollutes parser cache with localized version of “check entities against this schema” link
Closed, ResolvedPublic3 Story Points

Description

Problem:

  1. Set your user language to some non-English language.
  2. Edit a schema (text). (E12345 is our sandbox schema, prefer testing with that one.)
  3. Set your user language to English.
  4. The “check entities against this schema” link is still displayed in your other user language, not in English. (Assuming that message is already translated into the other language.)

For some reason, this does not seem to affect the “edit” link right next to it.

Example:
Can currently be seen at https://www.wikidata.org/wiki/EntitySchema:E12345, though the next edit or parser cache purge will break that example.

Screenshots/mockups:

Acceptance criteria:

  • A user always sees the text for "check entities against this schema" in their UI language or if that's not available a valid fallback language according to MediaWikis fallback chain

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 29 2019, 2:22 PM
Lydia_Pintscher moved this task from Incoming to Ready to estimate on the Wikidata-Campsite board.
WMDE-leszek set the point value for this task to 3.Jun 12 2019, 12:13 PM
Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptJul 5 2019, 10:23 AM

Change 520871 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/EntitySchema@master] Fragment ParserCache entries by language

https://gerrit.wikimedia.org/r/520871

Change 520871 merged by jenkins-bot:
[mediawiki/extensions/EntitySchema@master] Render schema check link in the renderer language

https://gerrit.wikimedia.org/r/520871