| • Ramsey-WMF | |
| May 29 2019, 8:46 PM |
| F29272064: quantity-firefox.PNG | |
| May 29 2019, 8:46 PM |
User story: N/A
We have this:
On Firefox, when attempting to add a quantity qualifier, the input box includes an extraneous and weird UI element for increment/decrement.
We want this:
There can be only one! (UI element for incrementing/decrementing values) [Highlander joke for the uninitiated]
Screenshots (if possible):
Acceptance Criteria:
I can look at this in the next couple of days, I'm poking around in Qualifier widget stuff anyway.
Change 516605 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/WikibaseMediaInfo@master] Disable number spinner arrows in Firefox
It's pretty easy to fix (patch up for review), but:
I'm not sure whether or not there's a good reason that this is not already handled in OOUI, so pinging @Volker_E for input.
Change 516605 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Disable number spinner arrows in Firefox
This is a known misbehaviour of Firefox, starting with v66, see T218977#5090020. I've revisited the vendor property fight again in the lastest patch in related task.
@Edtadros Firefox <=> 66 on all platforms, but at least Windows and macOS. Firefox 66 was the browser where support for -webkit prefixes came in and caused the issue.
@matthiasmullie We've added another fix upstream in OOUI, rolling out next release scheduled from next Tue on. When that's in, the code added here should be obsolete.
Change 519053 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/WikibaseMediaInfo@master] Remove unneeded browser behavior override
Change 519053 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Remove unneeded browser behavior override