Page MenuHomePhabricator

On Firefox, quantity qualifier input boxes show a mini increment/decrement UI element
Open, NormalPublicBug

Description

User story: N/A

We have this:
On Firefox, when attempting to add a quantity qualifier, the input box includes an extraneous and weird UI element for increment/decrement.

We want this:
There can be only one! (UI element for incrementing/decrementing values) [Highlander joke for the uninitiated]

Screenshots (if possible):

Acceptance Criteria:

  • On Firefox, quantity qualifier/statement UI elements do not contain any additional/extraneous UI elements

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 29 2019, 8:46 PM
Ramsey-WMF triaged this task as Normal priority.May 29 2019, 8:47 PM
Ramsey-WMF moved this task from Untriaged to Next up on the Multimedia board.
Ramsey-WMF added a subscriber: egardner.

Maybe another one @egardner can check out quickly 😄

I can look at this in the next couple of days, I'm poking around in Qualifier widget stuff anyway.

Change 516605 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/WikibaseMediaInfo@master] Disable number spinner arrows in Firefox

https://gerrit.wikimedia.org/r/516605

matthiasmullie moved this task from To Do to Code Review on the Multimedia-Current-Work board.

It's pretty easy to fix (patch up for review), but:

  • this is default Firefox behavior
  • and while OOUI adds its own in-/decrease controls, it doesn't override that behavior

I'm not sure whether or not there's a good reason that this is not already handled in OOUI, so pinging @Volker_E for input.

Ramsey-WMF moved this task from To Do to Doing on the SDC Engineering board.Jun 12 2019, 6:23 PM

Change 516605 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Disable number spinner arrows in Firefox

https://gerrit.wikimedia.org/r/516605

This is a known misbehaviour of Firefox, starting with v66, see T218977#5090020. I've revisited the vendor property fight again in the lastest patch in related task.

Edtadros added a subscriber: Edtadros.

@matthiasmullie which environment should this be tested in?

@Edtadros Firefox <=> 66 on all platforms, but at least Windows and macOS. Firefox 66 was the browser where support for -webkit prefixes came in and caused the issue.
@matthiasmullie We've added another fix upstream in OOUI, rolling out next release scheduled from next Tue on. When that's in, the code added here should be obsolete.

Change 519053 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/WikibaseMediaInfo@master] Remove unneeded browser behavior override

https://gerrit.wikimedia.org/r/519053

Change 519053 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Remove unneeded browser behavior override

https://gerrit.wikimedia.org/r/519053