As wmf deployed extension the ReadingLists extension should run phan on CI to found simple bugs in an earlier state of development.
The extension is using a trait for documentation of the database result wrapper, which makes phan very unhappy
See https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/ReadingLists/+/509533/ for a first removable, but a replacement was requested. I have no idea how or what to do.
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | None | T179554 Add phan to MediaWiki extensions and skins for static analysis [cloneable] | |||
| Resolved | Umherirrender | T224783 Enable mediawiki/mediawiki-phan-config on all Wikimedia-deployed repositories | |||
| Resolved | Umherirrender | T224762 Add phan to ReadingLists extension |
Change 514062 had a related patch set uploaded (by Gergő Tisza; owner: Gergő Tisza):
[mediawiki/extensions/ReadingLists@master] Add phan
Change 514062 abandoned by Gergő Tisza:
Add phan
Reason:
Seems way too much effort, as long as Phan offers no way of specifying the interface / base class of classes using a trait.
Phan doesn't seem usable for code which makes use of traits, where the trait is always applied to classes with a given interface or base class, and makes use of the available methods (the kind of trait that would have a require in Hack). I think the most we can do here is to make sure that the appropriate upstream feature requests exist.
Change 542752 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[integration/config@master] [ReadingLists] Add phan dependency
Change 542753 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/ReadingLists@master] build: Add mediawiki/mediawiki-phan-config
Change 542752 merged by jenkins-bot:
[integration/config@master] [ReadingLists] Add phan dependency
Change 543179 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[integration/config@master] layout: [ReadingLists] Enable Phan
Change 543179 merged by jenkins-bot:
[integration/config@master] layout: [ReadingLists] Enable Phan
Mentioned in SAL (#wikimedia-releng) [2019-10-15T17:33:58Z] <James_F> Zuul: Enable Phan for ReadingLists T224762
Change 542753 merged by jenkins-bot:
[mediawiki/extensions/ReadingLists@master] build: Add mediawiki/mediawiki-phan-config