Page MenuHomePhabricator
Create Task
Maniphest T224763

Add phan to DonationInterface extension
Closed, ResolvedPublic
Actions

Description

As wmf deployed extension the DonationInterface extension should run phan on CI to found simple bugs in an earlier state of development.

The extension is not using the common folder structure, it also has more vendor packages than other extensions which needs to be part of the config

Details

SubjectRepoBranchLines +/-
build: Expand the list of directories for phan to analyzemediawiki/extensions/DonationInterfacemaster+181 -99
Add phan configmediawiki/extensions/DonationInterfacemaster+22 -0
Zuul: [mediawiki/extensions/DonationInterface] Promote phan to votingintegration/configmaster+7 -24
Zuul: [mediawiki/extensions/DonationInterface] Add phan depsintegration/configmaster+3 -0
Zuul: [mediawiki/extensions/DonationInterface] Add phan as experimentalintegration/configmaster+2 -0
[DonationInterface] Add phan dependencyintegration/configmaster+1 -0
Build: Add mediawiki/mediawiki-phan-configmediawiki/extensions/DonationInterfacemaster+94 -10
Customize query in gerrit

Related Objects
Search...

Event Timeline

Umherirrender created this task.May 31 2019, 8:17 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 31 2019, 8:17 PM
Umherirrender added a parent task: T224783: Enable mediawiki/mediawiki-phan-config on all Wikimedia-deployed repositories.May 31 2019, 9:39 PM
Daimona moved this task from Backlog to Extensions on the phan board.Sep 12 2019, 5:49 PM
Umherirrender claimed this task.Oct 29 2019, 8:30 PM
Umherirrender triaged this task as Medium priority.
gerritbot added a comment.Oct 29 2019, 8:31 PM

Change 547031 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[integration/config@master] [DonationInterface] Add phan dependency

https://gerrit.wikimedia.org/r/547031

gerritbot added a project: Patch-For-Review.Oct 29 2019, 8:31 PM
Jdforrester-WMF updated the task description. (Show Details)Oct 30 2019, 5:32 PM
Jdforrester-WMF subscribed.

Note that DonationInterface runs against (a mild fork of) MediaWiki 1.31 on PHP 7.0 in production, and each patch has to be manually cherry-picked to production. Large-scale changes to this repo which can't be back-ported can't be merged, as they'd make it even worse to manage.

gerritbot added a comment.Oct 30 2019, 8:51 PM

Change 547308 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/DonationInterface@master] Build: Add mediawiki/mediawiki-phan-config

https://gerrit.wikimedia.org/r/547308

gerritbot added a comment.Oct 30 2019, 9:03 PM

Change 547308 abandoned by Umherirrender:
Build: Add mediawiki/mediawiki-phan-config

Reason:
See T224763#5620415
Feel free to restore or upload under your own name when interested in that work

https://gerrit.wikimedia.org/r/547308

gerritbot added a comment.Oct 30 2019, 9:04 PM

Change 547031 abandoned by Umherirrender:
[DonationInterface] Add phan dependency

Reason:
See T224763#5620415
Feel free to restore or upload under your own name when interested in that work

https://gerrit.wikimedia.org/r/547031

Umherirrender changed the task status from Open to Stalled.Oct 30 2019, 9:07 PM
Umherirrender removed Umherirrender as the assignee of this task.
Umherirrender lowered the priority of this task from Medium to Lowest.

I have upload my last patch set to publish the rest of the changed done. It would pass with some suppression, which needs a bit more work to find a clean solution.

Feel free to restore or upload under your own name when interested in that work

Maybe there is a time frame in the future to do it. if not interested on phan, feel free to decline this task to fix the decision.

Maintenance_bot removed a project: Patch-For-Review.Oct 30 2019, 9:10 PM
Jdforrester-WMF raised the priority of this task from Lowest to Medium.Apr 16 2020, 5:39 PM

Vague plan is to just wait for REL1_35 branch and do it from there.

Daimona merged a task: T202384: Add phan-taint-check-plugin to DonationInterface extension.Jul 3 2020, 10:24 AM
Daimona added subscribers: Bawolff, gerritbot.
Umherirrender unsubscribed.Feb 27 2021, 9:50 PM
Umherirrender added a project: Fundraising-Backlog.Oct 7 2023, 8:32 AM
Umherirrender updated the task description. (Show Details)
Umherirrender mentioned this in T182714: Run Phan on CentralNotice and DonationInterface.
AKanji-WMF assigned this task to Ejegg.Nov 6 2023, 9:07 PM
gerritbot added a comment.Nov 7 2023, 2:33 AM

Change 972076 had a related patch set uploaded (by Ejegg; author: Ejegg):

[mediawiki/extensions/DonationInterface@master] Add phan config

https://gerrit.wikimedia.org/r/972076

gerritbot added a project: Patch-For-Review.Nov 7 2023, 2:33 AM
gerritbot added a comment.Nov 7 2023, 2:39 AM

Change 972077 had a related patch set uploaded (by Jforrester; author: Jforrester):

[integration/config@master] Zuul: [mediawiki/extensions/DonationInterface] Add phan as experimental

https://gerrit.wikimedia.org/r/972077

gerritbot added a comment.Nov 7 2023, 2:41 AM

Change 972077 merged by jenkins-bot:

[integration/config@master] Zuul: [mediawiki/extensions/DonationInterface] Add phan as experimental

https://gerrit.wikimedia.org/r/972077

Stashbot added a comment.Nov 7 2023, 2:41 AM

Mentioned in SAL (#wikimedia-releng) [2023-11-07T02:41:53Z] <James_F> Zuul: [mediawiki/extensions/DonationInterface] Add phan as experimental for T224763

gerritbot added a comment.Nov 7 2023, 2:45 AM

Change 972078 had a related patch set uploaded (by Jforrester; author: Jforrester):

[integration/config@master] Zuul: [mediawiki/extensions/DonationInterface] Add phan deps

https://gerrit.wikimedia.org/r/972078

gerritbot added a comment.Nov 7 2023, 2:48 AM

Change 972078 merged by jenkins-bot:

[integration/config@master] Zuul: [mediawiki/extensions/DonationInterface] Add phan deps

https://gerrit.wikimedia.org/r/972078

Stashbot added a comment.Nov 7 2023, 2:48 AM

Mentioned in SAL (#wikimedia-releng) [2023-11-07T02:48:44Z] <James_F> Zuul: [mediawiki/extensions/DonationInterface] Add phan deps for T224763

gerritbot added a comment.Nov 7 2023, 2:54 AM

Change 972079 had a related patch set uploaded (by Jforrester; author: Jforrester):

[integration/config@master] Zuul: [mediawiki/extensions/DonationInterface] Promote phan to voting

https://gerrit.wikimedia.org/r/972079

Pppery changed the task status from Stalled to Open.Nov 8 2023, 1:12 AM
gerritbot added a comment.Nov 8 2023, 3:25 PM

Change 972076 merged by jenkins-bot:

[mediawiki/extensions/DonationInterface@master] Add phan config

https://gerrit.wikimedia.org/r/972076

gerritbot added a comment.Nov 8 2023, 3:25 PM

Change 972079 merged by jenkins-bot:

[integration/config@master] Zuul: [mediawiki/extensions/DonationInterface] Promote phan to voting

https://gerrit.wikimedia.org/r/972079

Stashbot added a comment.Nov 8 2023, 3:27 PM

Mentioned in SAL (#wikimedia-releng) [2023-11-08T15:27:36Z] <James_F> Zuul: [mediawiki/extensions/DonationInterface] Promote phan to voting for T224763

Jdforrester-WMF closed this task as Resolved.Nov 8 2023, 3:27 PM
Ejegg moved this task from Triage to Current Sprint on the Fundraising-Backlog board.Nov 8 2023, 3:29 PM
Ejegg added a project: Fundraising Sprint Uptown cURL.
Ejegg edited projects, added Fundraising Sprint vvv - tell me more; removed Fundraising Sprint Uptown cURL.
Ejegg moved this task from Backlog to Done on the Fundraising Sprint vvv - tell me more board.
Maintenance_bot removed a project: Patch-For-Review.Nov 8 2023, 3:30 PM
ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.5; 2023-11-14).Nov 8 2023, 4:00 PM
gerritbot added a comment.Apr 22 2024, 8:11 PM

Change #1015093 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/DonationInterface@master] build: Expand the list of directories for phan to analyze

https://gerrit.wikimedia.org/r/1015093

gerritbot added a project: Patch-For-Review.Apr 22 2024, 8:11 PM
gerritbot added a comment.May 1 2024, 2:07 AM

Change #1015093 merged by jenkins-bot:

[mediawiki/extensions/DonationInterface@master] build: Expand the list of directories for phan to analyze

https://gerrit.wikimedia.org/r/1015093

Maintenance_bot removed a project: Patch-For-Review.May 1 2024, 2:30 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL