Page MenuHomePhabricator
Create Task
Maniphest T225351

Regression in diffing unreviewed changes in edit mode in FlaggedRevs
Closed, ResolvedPublic
Actions

Description

In T155878#5242912, @stjn wrote:

Big regression introduced with this change: the diff that shows to FlaggedRevs reviewers when there are any unreviewed changes can’t be shown anymore because diff toggle gets hidden upon loading. Some reviewers probably won’t be happy with this. I don’t know how we’re going to fix this if there won’t be any deployments for 2 weeks, though.

(Ideally, this old code shouldn’t use bootleg toggles and should use jquery.makeCollapsible, but alas.)

Reproduce (look for #mw-diff-toggle in browser console):
https://ru.wikipedia.org/wiki/Кох,_Ганс?action=edit

Change that caused this:
https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/FlaggedRevs/+/338215/22/frontend/modules/ext.flaggedRevs.advanced.js

Details

SubjectRepoBranchLines +/-
Bring back diff togglemediawiki/extensions/FlaggedRevswmf/1.34.0-wmf.8+2 -0
Bring back diff togglemediawiki/extensions/FlaggedRevsmaster+2 -0
Customize query in gerrit

Related Objects

Event Timeline

Ladsgroup created this task.Jun 8 2019, 1:17 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 8 2019, 1:17 PM
Ladsgroup triaged this task as High priority.Jun 8 2019, 1:19 PM
Ladsgroup mentioned this in T155878: Use OOUI icons for FlaggedRevs.
Aklapper renamed this task from Regression in diffing unreviewed changes in edit mode in FalggedRevs to Regression in diffing unreviewed changes in edit mode in FlaggedRevs.Jun 8 2019, 1:35 PM
gerritbot added a comment.Jun 8 2019, 1:52 PM

Change 515628 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/FlaggedRevs@master] Bring back diff toggle

https://gerrit.wikimedia.org/r/515628

gerritbot added a project: Patch-For-Review.Jun 8 2019, 1:52 PM
gerritbot added a comment.Jun 8 2019, 4:32 PM

Change 515628 merged by jenkins-bot:
[mediawiki/extensions/FlaggedRevs@master] Bring back diff toggle

https://gerrit.wikimedia.org/r/515628

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.10; 2019-06-18).Jun 8 2019, 5:01 PM
Maintenance_bot removed a project: Patch-For-Review.Jun 8 2019, 5:10 PM
gerritbot added a comment.Jun 8 2019, 7:00 PM

Change 515773 had a related patch set uploaded (by Jforrester; owner: Ladsgroup):
[mediawiki/extensions/FlaggedRevs@wmf/1.34.0-wmf.8] Bring back diff toggle

https://gerrit.wikimedia.org/r/515773

gerritbot added a project: Patch-For-Review.Jun 8 2019, 7:00 PM
SerDIDG subscribed.Jun 8 2019, 8:03 PM
gerritbot added a comment.Jun 17 2019, 6:02 PM

Change 515773 merged by jenkins-bot:
[mediawiki/extensions/FlaggedRevs@wmf/1.34.0-wmf.8] Bring back diff toggle

https://gerrit.wikimedia.org/r/515773

Jdforrester-WMF closed this task as Resolved.Jun 17 2019, 6:07 PM
Jdforrester-WMF assigned this task to Ladsgroup.
Jdforrester-WMF edited projects, added MW-1.34-notes (1.34.0-wmf.8; 2019-06-04); removed Patch-For-Review, MW-1.34-notes (1.34.0-wmf.10; 2019-06-18).
Jdforrester-WMF subscribed.

Deployed.

Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptJun 17 2019, 6:07 PM
Stashbot added a comment.Jun 17 2019, 6:07 PM

Mentioned in SAL (#wikimedia-operations) [2019-06-17T18:07:17Z] <jforrester@deploy1001> Synchronized php-1.34.0-wmf.8/extensions/FlaggedRevs/frontend/modules/ext.flaggedRevs.advanced.js: SWAT: FlaggedRevs: Bring back diff toggle T225351 (duration: 00m 48s)

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits