Page MenuHomePhabricator

Add Redux to MobileFrontend
Open, MediumPublic

Description

NOTE: this task is a draft and should be considered work in progress until resolution or this notice is removed.

The purpose of this task is to install Redux as an NPM dependency, add any tooling changes needed, initialize the library on application entry, and identify the first part of the codebase to be changed to use the new functionality.

The Redux library has been in use for a long time in the Popups extension so a security review should be unnecessary so long as only Redux and redux-thunk are used.

Initialization should reference Popups's implementation.

Acceptance criteria

  • The latest version of Redux is installed in MobileFrontend, initialized on entry, and ready for use.
  • Any changes needed to the Webpack and test configurations are considered.
  • Document merge and deploy dates, and gzipped increases on the release timeline.
  • Deprecations are noted where applicable.
  • A part of the code is identified for the initial use and a new subtask of T225455 is made. The new task should require setting good usage patterns, any considerations that should be made for testing Redux'd code, adding any additional documentation necessary, and identifying subsequent subtasks to be made.

Details

Related Gerrit Patches:
mediawiki/extensions/MobileFrontend : masterSimplify Drawers via Redux state management
mediawiki/extensions/MobileFrontend : masterOverlays to use Redux state management (simplified OverlayManager)

Related Objects

Event Timeline

Niedzielski updated the task description. (Show Details)Jun 11 2019, 12:49 AM
Niedzielski updated the task description. (Show Details)Jun 13 2019, 1:53 PM

Change 524314 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] Simplify Drawers via Redux statement

https://gerrit.wikimedia.org/r/524314

Change 525177 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] Overlays to use Redux state management

https://gerrit.wikimedia.org/r/525177

Jdlrobson triaged this task as Medium priority.Aug 2 2019, 6:10 PM