namespaceDupes.php doesn't fix everything for eswikibooks
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	Urbanecm
	Jun 18 2019, 4:45 PM

Description

urbanecm@mwmaint1002:~$ mwscript namespaceDupes.php --wiki eswikibooks --add-prefix=T216143
0 pages to fix, 0 were resolvable.

pagelinks from=42536 ns=0 dbk=WL:Café -> Wikilibros:Café DRY RUN
1 links to fix, 1 were resolvable.

Looks good!
urbanecm@mwmaint1002:~$ mwscript namespaceDupes.php --wiki eswikibooks --add-prefix=T216143 --fix
0 pages to fix, 0 were resolvable.

pagelinks from=42536 ns=0 dbk=WL:Café -> Wikilibros:Café
1 links to fix, 1 were resolvable.

Looks good!
urbanecm@mwmaint1002:~$ mwscript namespaceDupes.php --wiki eswikibooks --add-prefix=T216143
0 pages to fix, 0 were resolvable.

pagelinks from=42536 ns=0 dbk=WL:Café -> Wikilibros:Café DRY RUN
1 links to fix, 1 were resolvable.

Looks good!
urbanecm@mwmaint1002:~$

Why doesn't namespaceDupes.php fix this problem it reports as "resolvable"?

Details

	Subject	Repo	Branch	Lines +/-
	namespaceDupes.php: Delete links if they still exist after UPDATE	mediawiki/core	master	+82 -16

Customize query in gerrit

Related Objects

Mentioned In: T115824: namespaceDupes.php causes duplicate entry db errors on some updates
T294495: diqwiki: namespaceDupes.php complains about invalid entries
T216143: Set new namespace aliases for es.wikibooks

Event Timeline

Urbanecm created this task.Jun 18 2019, 4:45 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 18 2019, 4:45 PM

Urbanecm mentioned this in T216143: Set new namespace aliases for es.wikibooks.Jun 18 2019, 4:45 PM

DannyS712 moved this task from Backlog to namespaceDupes.php on the MediaWiki-Maintenance-system board.Nov 22 2019, 7:00 AM

Reedy merged a task: T251569: `namespaceDupes.php --fix` not fixing links?.Apr 30 2020, 8:44 PM

Reedy added subscribers: Reedy, MarcoAurelio.

I'm guessing it's due to UPDATE IGNORE

Rows for which duplicate-key conflicts occur are not updated.

If the row isn't updated, should it just get deleted?

Of course, $dbw->update() doesn't tell us anything useful...

Change 593630 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/core@master] namespaceDupes.php: Delete links if they still exist after UPDATE

https://gerrit.wikimedia.org/r/593630

gerritbot added a project: Patch-For-Review.Apr 30 2020, 10:44 PM

Change 593630 merged by jenkins-bot:
[mediawiki/core@master] namespaceDupes.php: Delete links if they still exist after UPDATE

https://gerrit.wikimedia.org/r/593630

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.31; 2020-05-05).May 1 2020, 6:00 PM

Maintenance_bot removed a project: Patch-For-Review.May 1 2020, 6:10 PM

Umherirrender mentioned this in T294495: diqwiki: namespaceDupes.php complains about invalid entries.Dec 9 2021, 7:42 PM

Umherirrender closed this task as Resolved.Dec 9 2021, 7:46 PM

Umherirrender mentioned this in T115824: namespaceDupes.php causes duplicate entry db errors on some updates.