Page MenuHomePhabricator

phan is broken on master of Wikibase
Closed, ResolvedPublic

Description

We can't merge anything on Wikibase right now: https://integration.wikimedia.org/ci/job/mwext-php72-phan-docker/59/console (https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/517690)

<checkstyle version="6.5">
11:02:58   <file name="data-access/src/GenericServices.php">
11:02:58     <error line="171" severity="warning" message="Reference to deprecated property \Wikibase\DataModel\SerializerFactory::OPTION_SERIALIZE_MAIN_SNAKS_WITHOUT_HASH defined at ../../vendor/wikibase/data-model-serialization/src/SerializerFactory.php:43" source="PhanDeprecatedClassConstant"/>
11:02:58     <error line="172" severity="warning" message="Reference to deprecated property \Wikibase\DataModel\SerializerFactory::OPTION_SERIALIZE_REFERENCE_SNAKS_WITHOUT_HASH defined at ../../vendor/wikibase/data-model-serialization/src/SerializerFactory.php:53" source="PhanDeprecatedClassConstant"/>
11:02:58   </file>
11:02:58 </checkstyle>

Details

Related Gerrit Patches:
mediawiki/extensions/Wikibase : masterMigrate deprecated constant to fix phan error
mediawiki/extensions/Wikibase : wmf/1.34.0-wmf.10Migrate deprecated constant to fix phan error
mediawiki/extensions/Wikibase : masterSuppress phan deprecation error

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 19 2019, 9:31 AM
Michael triaged this task as High priority.Jun 19 2019, 10:41 AM

Change 517836 had a related patch set uploaded (by Michael Große; owner: Michael Große):
[mediawiki/extensions/Wikibase@master] Migrate deprecated constant to fix phan error

https://gerrit.wikimedia.org/r/517836

Change 517837 had a related patch set uploaded (by Michael Große; owner: Michael Große):
[mediawiki/extensions/Wikibase@master] Suppress phan deprecation error

https://gerrit.wikimedia.org/r/517837

I added two patches for this problem. Both should fix the error (let's see what CI says), but I do not enough insight to decide which is the better way to go for now. Please review them and tell me which to abandon.

Change 517836 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Migrate deprecated constant to fix phan error

https://gerrit.wikimedia.org/r/517836

Change 517837 abandoned by Michael Große:
Suppress phan deprecation error

Reason:
the alternative patch https://gerrit.wikimedia.org/r/517836 has been fixed

https://gerrit.wikimedia.org/r/517837

Restricted Application added a project: User-Michael. · View Herald TranscriptJun 19 2019, 12:29 PM

Change 518833 had a related patch set uploaded (by Jforrester; owner: Michael Große):
[mediawiki/extensions/Wikibase@wmf/1.34.0-wmf.10] Migrate deprecated constant to fix phan error

https://gerrit.wikimedia.org/r/518833

Change 518833 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@wmf/1.34.0-wmf.10] Migrate deprecated constant to fix phan error

https://gerrit.wikimedia.org/r/518833

mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:06 PM