Page MenuHomePhabricator
Create Task
Maniphest T226083

phan is broken on master of Wikibase
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

We can't merge anything on Wikibase right now: https://integration.wikimedia.org/ci/job/mwext-php72-phan-docker/59/console (https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/517690)

<checkstyle version="6.5">
11:02:58   <file name="data-access/src/GenericServices.php">
11:02:58     <error line="171" severity="warning" message="Reference to deprecated property \Wikibase\DataModel\SerializerFactory::OPTION_SERIALIZE_MAIN_SNAKS_WITHOUT_HASH defined at ../../vendor/wikibase/data-model-serialization/src/SerializerFactory.php:43" source="PhanDeprecatedClassConstant"/>
11:02:58     <error line="172" severity="warning" message="Reference to deprecated property \Wikibase\DataModel\SerializerFactory::OPTION_SERIALIZE_REFERENCE_SNAKS_WITHOUT_HASH defined at ../../vendor/wikibase/data-model-serialization/src/SerializerFactory.php:53" source="PhanDeprecatedClassConstant"/>
11:02:58   </file>
11:02:58 </checkstyle>

Details

SubjectRepoBranchLines +/-
Migrate deprecated constant to fix phan errormediawiki/extensions/Wikibasemaster+1 -2
Migrate deprecated constant to fix phan errormediawiki/extensions/Wikibasewmf/1.34.0-wmf.10+1 -2
Suppress phan deprecation errormediawiki/extensions/Wikibasemaster+2 -0
Customize query in gerrit

Event Timeline

Ladsgroup created this task.Jun 19 2019, 9:31 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 19 2019, 9:31 AM
• Pablo-WMDE subscribed.Jun 19 2019, 9:55 AM
Michael subscribed.Jun 19 2019, 10:05 AM
Michael triaged this task as High priority.Jun 19 2019, 10:41 AM
gerritbot added a comment.Jun 19 2019, 11:43 AM

Change 517836 had a related patch set uploaded (by Michael Große; owner: Michael Große):
[mediawiki/extensions/Wikibase@master] Migrate deprecated constant to fix phan error

https://gerrit.wikimedia.org/r/517836

gerritbot added a project: Patch-For-Review.Jun 19 2019, 11:43 AM

Change 517837 had a related patch set uploaded (by Michael Große; owner: Michael Große):
[mediawiki/extensions/Wikibase@master] Suppress phan deprecation error

https://gerrit.wikimedia.org/r/517837

Michael added a comment.Jun 19 2019, 11:45 AM

I added two patches for this problem. Both should fix the error (let's see what CI says), but I do not enough insight to decide which is the better way to go for now. Please review them and tell me which to abandon.

gerritbot added a comment.Jun 19 2019, 12:26 PM

Change 517836 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Migrate deprecated constant to fix phan error

https://gerrit.wikimedia.org/r/517836

gerritbot added a comment.Jun 19 2019, 12:28 PM

Change 517837 abandoned by Michael Große:
Suppress phan deprecation error

Reason:
the alternative patch https://gerrit.wikimedia.org/r/517836 has been fixed

https://gerrit.wikimedia.org/r/517837

Ladsgroup assigned this task to Michael.Jun 19 2019, 12:29 PM
Ladsgroup moved this task from To Do (prioritised from top to bottom) to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Restricted Application added a project: User-Michael. · View Herald TranscriptJun 19 2019, 12:29 PM
ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.11; 2019-06-26).Jun 19 2019, 1:00 PM
WMDE-leszek closed this task as Resolved.Jun 19 2019, 3:17 PM
WMDE-leszek moved this task from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
WMDE-leszek subscribed.

https://gerrit.wikimedia.org/r/517836 seems to have solved the problem

gerritbot added a comment.Jun 24 2019, 10:38 PM

Change 518833 had a related patch set uploaded (by Jforrester; owner: Michael Große):
[mediawiki/extensions/Wikibase@wmf/1.34.0-wmf.10] Migrate deprecated constant to fix phan error

https://gerrit.wikimedia.org/r/518833

gerritbot added a comment.Jun 24 2019, 11:38 PM

Change 518833 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@wmf/1.34.0-wmf.10] Migrate deprecated constant to fix phan error

https://gerrit.wikimedia.org/r/518833

ReleaseTaggerBot edited projects, added MW-1.34-notes (1.34.0-wmf.10; 2019-06-18); removed MW-1.34-notes (1.34.0-wmf.11; 2019-06-26).Jun 25 2019, 12:00 AM
• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:06 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits