Phan job fails on CI for mediawiki/core REL1_3[12]
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	hashar
	Jun 20 2019, 8:08 AM

Description

mediawiki/core branch fundraising/REL1_31 is for php7.0. CI triggers the php7.2 based Phan mediawiki-core-php72-phan-docker and it thus fail:

+ cd /mediawiki/
+ '[' '!' -f .phan/config.php ']'
+ '[' '!' -f tests/phan/config.php ']'
+ jq -e '.extra."phan"' composer.json
null
+ CFG_COMPOSER=vendor/mediawiki/mediawiki-phan-config/composer.json
+ jq -e '.extra."phan"' vendor/mediawiki/mediawiki-phan-config/composer.json
jq: error: Could not open file vendor/mediawiki/mediawiki-phan-config/composer.json: No such file or directory
+ PHAN_VERSION=0.8
+ export COLUMNS=80
+ COLUMNS=80
+ '[' -f .phan/config.php ']'
+ export PHP_ARGS=-dextension=ast_012.so
+ PHP_ARGS=-dextension=ast_012.so
+ install_phan
+ cd /srv/phan
+ composer require phan/phan:0.8

                                                                                                      
  [InvalidArgumentException]                                                                          
  Package phan/phan at version 0.8 has a PHP requirement incompatible with your PHP version (7.2.16)

Dummy change for testing: https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/517986/

Should we backport a more recent Phan for that branch? Or else we would need to keep supporting php7.0 which is the current target for the fundraising cluster. Ideally, the fundraising branch should be aiming at php 7.2 but that is a different task I guess.

Details

Subject	Repo	Branch	Lines +/-
layout: Restrict Phan jobs to only run on master, wmf/, & fundraising/ branches	integration/config	master	+3 -5
Skip mediawiki-core-php72-phan-docker on REL1_3[12]	integration/config	master	+2 -2
Skip php7.2 phan analysis for fundraising/REL1_31	integration/config	master	+2 -1

Customize query in gerrit

Related Objects

Mentioned In: T226945: Decide on future of running Phan tests on release branches
T226244: Phan fails with php72 on WikibaseLexeme

Event Timeline

hashar created this task.Jun 20 2019, 8:08 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 20 2019, 8:08 AM

Change 517988 had a related patch set uploaded (by Hashar; owner: Hashar):
[integration/config@master] Skip php7.2 phan analysis for fundraising/REL1_31

https://gerrit.wikimedia.org/r/517988

gerritbot added a project: Patch-For-Review.Jun 20 2019, 8:12 AM

Change 517988 merged by jenkins-bot:
[integration/config@master] Skip php7.2 phan analysis for fundraising/REL1_31

https://gerrit.wikimedia.org/r/517988

Maintenance_bot removed a project: Patch-For-Review.Jun 20 2019, 9:10 AM

Michael mentioned this in T226244: Phan fails with php72 on WikibaseLexeme.Jun 21 2019, 10:13 AM

Jgreen edited projects, added Fundraising-Backlog; removed fundraising-tech-ops.Jun 25 2019, 9:42 PM

Not actually just FR, it's REL1_31 and REL1_32 generally. Not sure if REL1_33 too

Change 519793 had a related patch set uploaded (by Reedy; owner: Reedy):
[integration/config@master] Skip mediawiki-core-php72-phan-docker on REL1_3[12]

https://gerrit.wikimedia.org/r/519793

gerritbot added a project: Patch-For-Review.Jun 30 2019, 5:01 PM

Change 519793 merged by jenkins-bot:
[integration/config@master] Skip mediawiki-core-php72-phan-docker on REL1_3[12]

https://gerrit.wikimedia.org/r/519793

Reedy closed this task as Resolved.Jun 30 2019, 5:09 PM

Reedy claimed this task.

Reedy removed a project: Patch-For-Review.

Reedy mentioned this in T226945: Decide on future of running Phan tests on release branches.Jun 30 2019, 9:35 PM

Change 525878 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[integration/config@master] layout: Restrict Phan jobs to only run on master, wmf/, & fundraising/ branches

https://gerrit.wikimedia.org/r/525878

gerritbot added a project: Patch-For-Review.Jul 27 2019, 12:40 AM

Change 525878 abandoned by Jforrester:
[integration/config@master] layout: Restrict Phan jobs to only run on master, wmf/, & fundraising/ branches

Reason:
This was done by default when we split the branches into their own pipelines.