Don't send coordinator comment notification email if user isn't currently the coordinator
Open, MediumPublic
Actions

Assigned To

None

Authored By

	• Samwalton9-WMF
	Jun 24 2019, 8:50 AM

Description

We had a case this week where an application for which a user was _previously_ the coordinator received an application. Because the platform sends emails to the last coordinator to make a change to the application (https://github.com/WikipediaLibrary/TWLight/blob/master/TWLight/emails/tasks.py#L186), they received an email despite not currently being the coordinator for this partner.

We should do a check before sending this email that the coordinator we're about the email is also the _current_ coordinator.

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T240146 Improve coordinator workflows
		Open		None	T226369 Don't send coordinator comment notification email if user isn't currently the coordinator

Event Timeline

• Samwalton9-WMF created this task.Jun 24 2019, 8:50 AM

Restricted Application added subscribers: Sadads, Aklapper. · View Herald TranscriptJun 24 2019, 8:50 AM

• Samwalton9-WMF triaged this task as Medium priority.Jun 26 2019, 2:04 PM

• Samwalton9-WMF added projects: good first task, Google-Code-in-2019.Sep 11 2019, 2:46 PM

Imported into GCI site as https://codein.withgoogle.com/tasks/5179664797007870/

Urbanecm moved this task from Proposed tasks to Imported in GCI Site on the Google-Code-in-2019 board.Oct 29 2019, 7:31 PM

Nikkimaria added a parent task: T240146: Improve coordinator workflows.Dec 8 2019, 9:28 PM

• Samwalton9-WMF merged a task: T240147: Forward emails to new coordinator.Jan 31 2020, 7:05 PM

• Samwalton9-WMF added a subscriber: Nikkimaria.

lalit97 claimed this task.Feb 5 2020, 9:11 AM

Hello @Samwalton9 I have raised a pull request for this at https://github.com/WikipediaLibrary/TWLight/pull/406

• Samwalton9-WMF moved this task from Open tasks to Doing on the Library-Card-Platform board.Feb 18 2020, 11:49 AM

• Samwalton9-WMF edited projects, added Patch-For-Review; removed Google-Code-in-2019.

• Samwalton9-WMF moved this task from Doing to Done on the Library-Card-Platform board.Apr 8 2020, 1:21 PM

This comment was removed by • Samwalton9-WMF.

• Samwalton9-WMF moved this task from Done to Doing on the Library-Card-Platform board.Apr 8 2020, 1:22 PM

• Samwalton9-WMF moved this task from Doing to Open tasks on the Library-Card-Platform board.Jun 3 2020, 1:45 PM

• Samwalton9-WMF mentioned this in T254562: Review backlog of open pull requests.Jun 5 2020, 10:24 AM

• Samwalton9-WMF added a project: The-Wikipedia-Library (Kanban).Jul 10 2020, 10:21 AM

• Samwalton9-WMF moved this task from Ready to Review on the The-Wikipedia-Library (Kanban) board.

Scardenasmolinar moved this task from Review to Done on the The-Wikipedia-Library (Kanban) board.Aug 12 2020, 12:00 AM

Scardenasmolinar moved this task from Done to In Progress on the The-Wikipedia-Library (Kanban) board.Aug 12 2020, 6:56 PM

I have put this task back to In Progress because I merged the PR before time. @lalit97, can you still take care of this task and create a new PR? We can help you out in case you get stuck in a problem.

I have put this task back to In Progress because I merged the PR before time. @lalit97, can you still take care of this task and create a new PR? We can help you out in case you get stuck in a problem.

No problem I have raised a new PR at https://github.com/WikipediaLibrary/TWLight/pull/506. Also mentioned the issue I was facing in the comments :)

• Samwalton9-WMF moved this task from In Progress to Review on the The-Wikipedia-Library (Kanban) board.Sep 16 2020, 2:50 PM

I think a rewrite of the class setup might be in order. While that is in scope of the task, it's pretty clear that this isn't the "good-first-task" that we thought it was. We have significant work on the test suite in the backlog anyway, so you might just want to walk away from this one, unless test design in itself is of interest to you.

jsn.sherman mentioned this in T263850: Rewrite application revision handling in test suite.Sep 25 2020, 2:14 PM

I put this in the waiting for changes column: this isn't waiting for changes to the pr, it's waiting for other changes to the test suite.

In T226369#6494165, @jsn.sherman wrote:

I think a rewrite of the class setup might be in order. While that is in scope of the task, it's pretty clear that this isn't the "good-first-task" that we thought it was. We have significant work on the test suite in the backlog anyway, so you might just want to walk away from this one, unless test design in itself is of interest to you.

Okay I am leaving it here for now. If I understand any tasks related to this properly then I will try to add my contribution :)

We're going to prioritise T263850 soon, so hopefully you can revisit this work before too long :)

Okay I will look into it :)

Moving this into the backlog pending that task being completed.

• Samwalton9-WMF moved this task from Backlog to To be discussed on the The-Wikipedia-Library board.Oct 8 2020, 9:58 AM

• Samwalton9-WMF removed lalit97 as the assignee of this task.Jan 5 2021, 10:04 AM

• Samwalton9-WMF removed a project: good first task.

• Samwalton9-WMF removed a project: Patch-For-Review.

• Samwalton9-WMF added a subscriber: lalit97.

Hey @Samwalton9 once again! I think this issue still persists? Can I work on it ?

Paritosh_Kabra claimed this task.Jan 13 2022, 5:04 PM

lalit97 unsubscribed.Jan 14 2022, 5:18 AM

Hi @Paritosh_Kabra we identified that this task might be difficult to test until T263850 is worked on, and we don't plan to work on that soon, so you might want to pick another task.

Perhaps T298947 or T299037?

No Issues ! I will try other tasks mentioned by you

In T226369#7621947, @Samwalton9 wrote:

Hi @Paritosh_Kabra we identified that this task might be difficult to test until T263850 is worked on, and we don't plan to work on that soon, so you might want to pick another task.

Perhaps T298947 or T299037?

Paritosh_Kabra removed Paritosh_Kabra as the assignee of this task.Jan 15 2022, 4:19 PM

Paritosh_Kabra unsubscribed.

Paritosh_Kabra subscribed.

• Samwalton9-WMF mentioned this in T353476: Replace The Wikipedia Library's email functionality with a combination of platform features and Echo notifications.Dec 14 2023, 6:16 PM

Don't send coordinator comment notification email if user isn't currently the coordinatorOpen, MediumPublicActions

Description

Related ObjectsSearch...

Event Timeline

Don't send coordinator comment notification email if user isn't currently the coordinator
Open, MediumPublic
Actions

Related Objects
Search...