PHP error from CirrusSearch/RequestLogger: "Array to string conversion"
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Assigned To

Authored By

	Krinkle
	Jun 25 2019, 7:38 PM

Description

Error

Request URL: /w/api.php …
Request ID: XRJzVApAIDkAADTVaowAAADV

message

PHP Notice: Array to string conversion

trace

	#0 /srv/mediawiki/php-1.34.0-wmf.10/extensions/CirrusSearch/includes/RequestLogger.php(341): MWExceptionHandler::handleError(integer, string, string, integer, array, array)
#1 /srv/mediawiki/php-1.34.0-wmf.10/extensions/CirrusSearch/includes/RequestLogger.php(99): CirrusSearch\RequestLogger->buildCirrusSearchRequestEvent()
#2 /srv/mediawiki/php-1.34.0-wmf.10/extensions/CirrusSearch/includes/RequestLogger.php(128): CirrusSearch\RequestLogger->reportLogs()
#3 /srv/mediawiki/php-1.34.0-wmf.10/includes/deferred/MWCallableUpdate.php(38): Closure$CirrusSearch\RequestLogger::addRequest()
#4 /srv/mediawiki/php-1.34.0-wmf.10/includes/deferred/DeferredUpdates.php(309): MWCallableUpdate->doUpdate()
#5 /srv/mediawiki/php-1.34.0-wmf.10/includes/deferred/DeferredUpdates.php(265): DeferredUpdates::attemptUpdate(MWCallableUpdate, Wikimedia\Rdbms\LBFactoryMulti)
#6 /srv/mediawiki/php-1.34.0-wmf.10/includes/deferred/DeferredUpdates.php(217): DeferredUpdates::handleUpdate(MWCallableUpdate, Wikimedia\Rdbms\LBFactoryMulti, string, integer)
#7 /srv/mediawiki/php-1.34.0-wmf.10/includes/deferred/DeferredUpdates.php(144): DeferredUpdates::handleUpdateQueue(array, string, integer)
#8 /srv/mediawiki/php-1.34.0-wmf.10/includes/MediaWiki.php(907): DeferredUpdates::doUpdates(string)
#9 /srv/mediawiki/php-1.34.0-wmf.10/includes/MediaWiki.php(731): MediaWiki->restInPeace(string, boolean)
#10 [internal function]: Closure$MediaWiki::doPostOutputShutdown()

Impact

To be determined.

Notes

Started right after 1.34-wmf.10 was promoted to group2 Wikipedias. Not seen in the 30 days prior from any other deployment branch.

Details

	Subject	Repo	Branch	Lines +/-
	Convert array params to string when logging requests	mediawiki/extensions/CirrusSearch	wmf/1.34.0-wmf.11	+3 -0
	Convert array params to string when logging requests	mediawiki/extensions/CirrusSearch	master	+3 -0

Customize query in gerrit

Related Objects

Mentioned In: T235354: "PHP Notice: Array to string conversion" from CirrusSearch RequestLogger.php

Event Timeline

Krinkle created this task.Jun 25 2019, 7:38 PM

Restricted Application added a project: Discovery-Search. · View Herald TranscriptJun 25 2019, 7:38 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Krinkle moved this task from Untriaged to Jun 2019 / 1.34.wmf.8+ on the Wikimedia-production-error board.Jun 25 2019, 8:00 PM

Change 519102 had a related patch set uploaded (by DCausse; owner: DCausse):
[mediawiki/extensions/CirrusSearch@master] Convert array params to string when logging requests

https://gerrit.wikimedia.org/r/519102

gerritbot added a project: Patch-For-Review.Jun 25 2019, 8:11 PM

dcausse claimed this task.Jun 25 2019, 8:12 PM

dcausse triaged this task as Medium priority.

dcausse moved this task from needs triage to Current work on the Discovery-Search board.

dcausse edited projects, added Discovery-Search (Current work); removed Discovery-Search.

dcausse moved this task from Incoming to Needs review on the Discovery-Search (Current work) board.

Change 519102 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@master] Convert array params to string when logging requests

https://gerrit.wikimedia.org/r/519102

Maintenance_bot removed a project: Patch-For-Review.Jun 25 2019, 9:10 PM

Change 519161 had a related patch set uploaded (by Krinkle; owner: DCausse):
[mediawiki/extensions/CirrusSearch@wmf/1.34.0-wmf.11] Convert array params to string when logging requests

https://gerrit.wikimedia.org/r/519161

gerritbot added a project: Patch-For-Review.Jun 26 2019, 1:20 AM

Smalyshev moved this task from Needs review to Needs Reporting on the Discovery-Search (Current work) board.Jun 26 2019, 5:57 AM

Change 519161 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@wmf/1.34.0-wmf.11] Convert array params to string when logging requests

https://gerrit.wikimedia.org/r/519161

Mentioned in SAL (#wikimedia-operations) [2019-06-26T12:01:19Z] <dcausse@deploy1001> Synchronized php-1.34.0-wmf.11/extensions/CirrusSearch/includes/RequestLogger.php: T226568: Convert array params to string when logging requests (duration: 00m 56s)

Maintenance_bot removed a project: Patch-For-Review.Jun 26 2019, 12:10 PM

Krinkle moved this task from Jun 2019 / 1.34.wmf.8+ to Resolved on the Wikimedia-production-error board.Jun 26 2019, 2:25 PM

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.11; 2019-06-26).Jun 26 2019, 7:02 PM

debt closed this task as Resolved.Jul 3 2019, 4:25 PM

• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:06 PM

Krinkle mentioned this in T235354: "PHP Notice: Array to string conversion" from CirrusSearch RequestLogger.php.Oct 12 2019, 10:56 PM