Page MenuHomePhabricator
Create Task
Maniphest T227009

selenium-daily-beta-Echo Jenkins job failing
Closed, ResolvedPublic
Actions

Description

1) Echo checks for welcome message after signup:
element (".mw-echo-ui-notificationItemWidget-content-message-header") still not visible after 10000ms
running chrome
Error: element (".mw-echo-ui-notificationItemWidget-content-message-header") still not visible after 10000ms
    at elements(".mw-echo-ui-notificationItemWidget-content-message-header") - isVisible.js:54:17
    at isVisible(".mw-echo-ui-notificationItemWidget-content-message-header") - waitForVisible.js:73:22

2) Mention test for Echo checks if admin gets alert when mentioned:
The expression evaluated to a falsy value:

  assert( regexp.test( EchoPage.alertMessage.getText() ) )

running chrome
AssertionError [ERR_ASSERTION]: The expression evaluated to a falsy value:

  assert( regexp.test( EchoPage.alertMessage.getText() ) )

    at Context.<anonymous> (/src/tests/selenium/specs/mention.js:24:3)
    at new Promise (<anonymous>)
    at new F (/src/node_modules/core-js/library/modules/_export.js:36:28)

Details

SubjectRepoBranchLines +/-
Skip broken Selenium testmediawiki/extensions/Echomaster+1 -1
WIP Fix failing test by removing some unicode charactersmediawiki/extensions/Echomaster+2 -2
Selenium: Fix failing test by only running tests tagged @dailymediawiki/extensions/Echomaster+7 -7
Selenium: Fix failing Jenkins job by disabling failing testsmediawiki/extensions/Echomaster+2 -2
Customize query in gerrit

Related Objects

Event Timeline

zeljkofilipin created this task.Jul 1 2019, 3:46 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptJul 1 2019, 3:46 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
zeljkofilipin triaged this task as Medium priority.Jul 1 2019, 3:46 PM
zeljkofilipin moved this task from Backlog 🪒 to Deep work 🌊 on the User-zeljkofilipin board.
gerritbot added a comment.Jul 1 2019, 3:48 PM

Change 520036 had a related patch set uploaded (by Zfilipin; owner: Zfilipin):
[mediawiki/extensions/Echo@master] WIP Fix failing test by removing some unicode characters

https://gerrit.wikimedia.org/r/520036

gerritbot added a project: Patch-For-Review.Jul 1 2019, 3:48 PM

Change 520038 had a related patch set uploaded (by Zfilipin; owner: Zfilipin):
[mediawiki/extensions/Echo@master] Selenium: Fix failing Jenkins job by disabling failing tests

https://gerrit.wikimedia.org/r/520038

Krinkle updated the task description. (Show Details)Jul 1 2019, 4:10 PM
gerritbot added a comment.Jul 1 2019, 4:21 PM

Change 520038 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] Selenium: Fix failing Jenkins job by disabling failing tests

https://gerrit.wikimedia.org/r/520038

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.13; 2019-07-09).Jul 1 2019, 5:00 PM
gerritbot added a comment.Jul 4 2019, 1:56 AM

Change 520663 had a related patch set uploaded (by Ephemeralwaves; owner: Ephemeralwaves):
[mediawiki/extensions/Echo@master] WIP Fix failing test by only running tests tagged @daily

https://gerrit.wikimedia.org/r/520663

gerritbot added a comment.Jul 5 2019, 11:13 AM

Change 520663 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] Selenium: Fix failing test by only running tests tagged @daily

https://gerrit.wikimedia.org/r/520663

gerritbot added a comment.Jul 5 2019, 12:11 PM

Change 520036 abandoned by Zfilipin:
WIP Fix failing test by removing some unicode characters

Reason:
just a test

https://gerrit.wikimedia.org/r/520036

zeljkofilipin closed this task as Resolved.Jul 5 2019, 12:13 PM

All patches merged (bug:T227009), the job is green (selenium-daily-beta-Echo).

Maintenance_bot removed a project: Patch-For-Review.Jul 5 2019, 1:10 PM
kostajh reopened this task as Open.Jul 30 2019, 2:53 PM
kostajh subscribed.

One of these tests (Mention test for Echo checks if admin gets alert when mentioned) is now failing consistently in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Echo/+/524520

gerritbot added a comment.Jul 30 2019, 2:54 PM

Change 526440 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/extensions/Echo@master] Skip broken Selenium test

https://gerrit.wikimedia.org/r/526440

gerritbot added a project: Patch-For-Review.Jul 30 2019, 2:54 PM
gerritbot added a comment.Jul 30 2019, 3:52 PM

Change 526440 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] Skip broken Selenium test

https://gerrit.wikimedia.org/r/526440

ReleaseTaggerBot edited projects, added MW-1.34-notes (1.34.0-wmf.16; 2019-07-30); removed MW-1.34-notes (1.34.0-wmf.13; 2019-07-09).Jul 30 2019, 4:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jul 30 2019, 4:11 PM
• Catrope closed this task as Resolved.Jul 31 2019, 1:45 AM
• Catrope subscribed.

Patch was merged, job is no longer failing

Reedy mentioned this in T294367: element (".mw-echo-ui-notificationItemWidget-content-message-header") still not displayed after 5000ms.Oct 26 2021, 5:04 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits