Page MenuHomePhabricator
Create Task
Maniphest T228001

Create an initial set of API integration tests using variables (part 1)
Closed, ResolvedPublic
Actions

Description

Without support for variables in phester, these tests have to be written "dry", with no way to execute them.

  • watchlist (watch/unwatch/auto-watch)
  • bot edits (interaction of bot permission and bot parameter)
  • rollback
  • patrolling, patrol log
  • listing user contributions
  • page deletion/undeletion (effectiveness)
  • user blocking (effectiveness, various options)
  • user script protection (can only edit own)
  • minor edits
  • remaining core magic words (in particular REVISIONID and friends)
  • Special pages transclusion
  • media file uploads (need to be enabled on the wiki) (needs file upload support in phester)

These tests will be written for our own runner (phester) and some tests for some of the other candidates, like strest, tavern, behat, codeception, or dredd.

Tests to be written in other frameworks:

Acceptance criteria: at least half of the tests have been written using Phester and at least two of them have been written in at least two other frameworks.

Related Objects
Search...

Event Timeline

CCicalese_WMF created this task.Jul 15 2019, 2:09 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 15 2019, 2:09 AM
CCicalese_WMF triaged this task as Medium priority.Jul 15 2019, 2:10 AM
CCicalese_WMF renamed this task from Create a set of API integration tests using variables to Create an initial set of API integration tests using variables.Jul 15 2019, 8:37 PM
CCicalese_WMF added a parent task: T222100: Decide whether creating Phester is actually worth while.Jul 15 2019, 8:41 PM
CCicalese_WMF updated the task description. (Show Details)Jul 16 2019, 3:58 AM
CCicalese_WMF added a project: Platform Team Workboards (Epics).Jul 16 2019, 2:58 PM
CCicalese_WMF moved this task from Epic Backlog to Need User Stories on the Platform Team Workboards (Epics) board.
CCicalese_WMF updated the task description. (Show Details)Jul 17 2019, 5:44 PM
CCicalese_WMF updated the task description. (Show Details)Jul 17 2019, 5:49 PM
CCicalese_WMF moved this task from Epics to Architecture Review Workboard on the Platform Team Workboards board.Jul 17 2019, 6:12 PM
CCicalese_WMF edited projects, added Platform Team Workboards (Architecture Review Workboard); removed Platform Team Workboards (Epics).
CCicalese_WMF removed a project: Epic.
CCicalese_WMF renamed this task from Create an initial set of API integration tests using variables to Create an initial set of API integration tests using variables (part 1).Jul 17 2019, 6:25 PM
CCicalese_WMF assigned this task to daniel.
CCicalese_WMF removed a subtask: T228324: Create an initial set of API integration tests using variables (part 2).
CCicalese_WMF moved this task from Backlog to Next Sprint on the Platform Team Workboards (Architecture Review Workboard) board.Jul 17 2019, 6:30 PM
CCicalese_WMF moved this task from Next Sprint to Engineering Tasks Ready for Estimation on the Platform Team Workboards (Architecture Review Workboard) board.
• Clarakosi updated the task description. (Show Details)Jul 18 2019, 1:46 PM
• Fjalapeno moved this task from Engineering Tasks Ready for Estimation to Ready on the Platform Team Workboards (Architecture Review Workboard) board.Jul 23 2019, 1:46 PM
daniel moved this task from Ready to Doing on the Platform Team Workboards (Architecture Review Workboard) board.Jul 23 2019, 2:34 PM
• WDoranWMF moved this task from API Integration Tests to mop on the Platform Engineering board.Jul 26 2019, 7:09 PM
• WDoranWMF edited projects, added Core Platform Team Initiatives (API Integration Tests); removed Platform Engineering (API Integration Tests).
daniel added a comment.Jul 29 2019, 3:34 PM

Pull request for the majority of Phester tests is up:
https://github.com/clarakosi/Phester/pull/10

daniel updated the task description. (Show Details)Jul 29 2019, 3:41 PM
daniel updated the task description. (Show Details)Jul 29 2019, 4:10 PM
daniel updated the task description. (Show Details)Jul 29 2019, 4:32 PM
• Fjalapeno subscribed.Jul 29 2019, 4:52 PM

@daniel hey,. thanks for updating… just left this comment for Clara too:

Would you mind also creating a list for each additional framework you intend to test? (At says at least 2 but I'm not sure which ones you are doing and how many you think you will do)

• Fjalapeno added a comment.Jul 29 2019, 4:53 PM

@daniel whoops! you already did that… nm and thanks!

daniel updated the task description. (Show Details)Jul 30 2019, 12:35 PM

I tried to write a test in strest. It's next to impossible due to the lack of support for session contexts. We'd have to permanently log in and log out in order to write tests that involve multiple users. That's a show stopper.

daniel mentioned this in T229640: Example Tests.Aug 5 2019, 11:43 AM
• Fjalapeno moved this task from Doing to PM User Story Sign Off on the Platform Team Workboards (Architecture Review Workboard) board.Aug 6 2019, 4:24 PM

Not actually finished but now invalid due to Super test

CCicalese_WMF closed this task as Invalid.Aug 12 2019, 6:33 PM
CCicalese_WMF moved this task from PM User Story Sign Off to Done on the Platform Team Workboards (Architecture Review Workboard) board.
CCicalese_WMF changed the task status from Invalid to Resolved.Aug 12 2019, 7:34 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits