Drop deprecated wikibase.RepoApi{,Error}
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Ladsgroup
	Jul 15 2019, 4:20 PM

Description

These modules have been deprecated in favor of wikibase.api.RepoApi{,Error} more than 4.5 years ago. It's time to drop them:

ladsgroup@mwmaint1002:~$ mwgrep wikibase.RepoApi
ruwiki              MediaWiki:Gadget-wefinfobox.js

(total: 1, shown: 1)
ladsgroup@mwmaint1002:~$ mwgrep wikibase.RepoApi --user
dewiki              User:ערן/spellcheck.js
enwiki              User:ערן/spellcheck.js
hewiki              User:חסר כינוי/common.js
ruwiki              User:Vlsergey/common.js
wikidatawiki        User:Fomafix/MediaWiki:Gadget-FindRedirectsForAliases.js

(total: 5, shown: 5)

It probably need an announcement.

Details

	Subject	Repo	Branch	Lines +/-
	Drop deprecated wikibase.RepoApi{,Error}	mediawiki/extensions/Wikibase	master	+0 -65

Customize query in gerrit

Event Timeline

Ladsgroup created this task.Jul 15 2019, 4:20 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 15 2019, 4:20 PM

Change 523224 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/Wikibase@master] Drop deprecated wikibase.RepoApi{,Error}

https://gerrit.wikimedia.org/r/523224

gerritbot added a project: Patch-For-Review.Jul 15 2019, 4:21 PM

Ladsgroup updated the task description. (Show Details)Jul 15 2019, 4:22 PM

It probably need an announcement.

Strictly speaking it doesn’t, because Wikibase JavaScript code is explicitly not a stable interface according to the Stable Interface Policy. If you’ve already done the investigation, I guess it makes sense to notify those users, but on the other hand I’m not sure if it’s a good idea to treat the JavaScript code as if it’s more-or-less stable…

In T228074#5336761, @Lucas_Werkmeister_WMDE wrote:

It probably need an announcement.

Strictly speaking it doesn’t, because Wikibase JavaScript code is explicitly not a stable interface according to the Stable Interface Policy. If you’ve already done the investigation, I guess it makes sense to notify those users, but on the other hand I’m not sure if it’s a good idea to treat the JavaScript code as if it’s more-or-less stable…

Indeed. Let's just let them know and merge this. What do you think?

Sounds good to me.

Change 523224 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Drop deprecated wikibase.RepoApi{,Error}

https://gerrit.wikimedia.org/r/523224

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.15; 2019-07-23).Jul 16 2019, 2:01 PM

Maintenance_bot removed a project: Patch-For-Review.Jul 16 2019, 2:10 PM