Open switcher | Choose visual | Surface goes blank | VE finishes loading |
Description
Details
Related Objects
Event Timeline
We didn't really design for this case, but I would guess showing the * Editor loading spinner would suffice.
Ideally we'd grey out the wikitext surface instead of hiding it too, and change the copy to "Switching editor":
This is caused by rEMFRbd1b16ff18bc: Get rid of toHtmlString and simplify overlay header construction. Previously, a generic spinner would be shown when switching editors.
Switching… | …from source to visual | …from visual to source |
---|---|---|
Before | ||
After | ||
(The same change has also apparently broke the ellipsing of page title in wikitext editor.)
Change 523305 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/MobileFrontend@master] Fix truncating text with ellipsis in overlay headers
Change 523306 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/MobileFrontend@master] EditorOverlayBase: Fix spinner icon
Change 523305 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Fix truncating text with ellipsis in overlay headers
Change 523306 merged by Jdlrobson:
[mediawiki/extensions/MobileFrontend@master] EditorOverlayBase: Fix spinner icon
Nice catch @Esanders
The fix here should mirror the flow for the loading indicator when getting into Visual Editor.
We just fixed the regression, so it looks like it did before:
Making it look more like the VE loader should be added to our Q1 usability task list.