Page MenuHomePhabricator

No loading progress shown when switching from mobile wikitext to mobile VE
Closed, ResolvedPublic

Assigned To
Authored By
Esanders
Jul 15 2019, 7:37 PM
Referenced Files
F29781927: image.png
Jul 16 2019, 12:19 PM
F29775958: image.png
Jul 15 2019, 8:19 PM
F29775917: image.png
Jul 15 2019, 8:19 PM
F29775946: image.png
Jul 15 2019, 8:19 PM
F29775911: image.png
Jul 15 2019, 8:19 PM
F29775566: image.png
Jul 15 2019, 7:46 PM
F29775489: image.png
Jul 15 2019, 7:41 PM
F29775498: image.png
Jul 15 2019, 7:41 PM

Description

Open switcherChoose visualSurface goes blankVE finishes loading
image.png (655×377 px, 59 KB)
image.png (655×378 px, 60 KB)
image.png (653×375 px, 11 KB)
image.png (660×378 px, 64 KB)

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

We didn't really design for this case, but I would guess showing the * Editor loading spinner would suffice.

Ideally we'd grey out the wikitext surface instead of hiding it too, and change the copy to "Switching editor":

image.png (657×377 px, 57 KB)

This is caused by rEMFRbd1b16ff18bc: Get rid of toHtmlString and simplify overlay header construction. Previously, a generic spinner would be shown when switching editors.

Switching……from source to visual…from visual to source
Before
image.png (667×375 px, 10 KB)
image.png (667×375 px, 119 KB)
After
image.png (667×375 px, 9 KB)
image.png (667×375 px, 118 KB)

(The same change has also apparently broke the ellipsing of page title in wikitext editor.)

Change 523305 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/MobileFrontend@master] Fix truncating text with ellipsis in overlay headers

https://gerrit.wikimedia.org/r/523305

Change 523306 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/MobileFrontend@master] EditorOverlayBase: Fix spinner icon

https://gerrit.wikimedia.org/r/523306

Change 523305 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Fix truncating text with ellipsis in overlay headers

https://gerrit.wikimedia.org/r/523305

Change 523306 merged by Jdlrobson:
[mediawiki/extensions/MobileFrontend@master] EditorOverlayBase: Fix spinner icon

https://gerrit.wikimedia.org/r/523306

Nice catch @Esanders

The fix here should mirror the flow for the loading indicator when getting into Visual Editor.

We just fixed the regression, so it looks like it did before:

image.png (658×378 px, 12 KB)

Making it look more like the VE loader should be added to our Q1 usability task list.