Page MenuHomePhabricator

Notification icon should be visible when the notification drawer is open
Closed, ResolvedPublic3 Estimated Story Points

Description

Description

When the notification icon is clicked on tablet, the drawer opens and the notification hides. The notification icon should remain present on the screen.

Actual behaviour:

Screenshot 2019-07-24 at 8.33.17 AM.png (255×785 px, 45 KB)

Desired behaviour:

Screenshot 2019-07-24 at 8.33.13 AM.png (324×987 px, 80 KB)

Developer notes

This issue doesn't affect Safari

QA steps

Event Timeline

It might be a browser bug. I see the notification icon in safari, but not in chrome:

Screen Shot 2019-07-29 at 13.55.13.png (1×2 px, 795 KB)

Screen Shot 2019-07-29 at 13.55.03.png (1×2 px, 766 KB)

There are two competing rules so I'm guessing it's browser specific which wins

Specificity war!!! What is it good for...?

Jdlrobson added a subscriber: alexhollender_WMF.

@alexhollender so for me the question is should it be hidden or not. Can you answer that and retitle the task? Once we know that fixing this is pretty straightforward.

alexhollender_WMF renamed this task from Should notification icon be visible when the notification drawer is open? to Notification icon should be visible when the notification drawer is open.Jul 30 2019, 4:01 PM

@Jdlrobson sure, I've just retitled the task. I previous had updated the description to say:

The notification icon should remain present on the screen.

Apologies, I thought that was sufficient : )

Jdlrobson triaged this task as Medium priority.Jul 30 2019, 8:58 PM
Jdlrobson set the point value for this task to 3.Jul 31 2019, 5:26 PM

Change 527222 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] Do not hide notifications icon when drawer open

https://gerrit.wikimedia.org/r/527222

Change 527222 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Do not hide notifications icon when drawer open

https://gerrit.wikimedia.org/r/527222

alexhollender_WMF updated the task description. (Show Details)

✅confirming that this works

MacOS / Chrome browser

logged-inlogged-in + AMC
Screen Shot 2019-08-07 at 3.56.15 PM.png (1×1 px, 345 KB)
Screen Shot 2019-08-07 at 3.56.59 PM.png (1×1 px, 346 KB)
phuedx added a subscriber: phuedx.

Confirmed in Chrome (76.0.3809.100) on macOS Mojave (10.14.6) in production.