CI fails for WikibaseLexemeCirrusSearch unit tests due to missing class exported by WikibaseLexeme
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	dcausse
	Jul 29 2019, 10:47 AM

Description

WikibaseLexemeCirrusSearch quibble-vendor-mysql-hhvm-docker started to fail for no particular reason.
The failure is :

Fatal error: Class undefined: Wikibase\Lexeme\Tests\DataModel\NewForm in /workspace/src/extensions/WikibaseLexemeCirrusSearch/tests/phpunit/LexemeFieldTest.php on line 29

This class should be exported by WikibaseLexeme composer.json autoload:

"autoload": {
     "psr-4": {
        "Wikibase\\Lexeme\\": "src/",
        "Wikibase\\Lexeme\\Tests\\": "tests/phpunit/composer/"
     }
 },

but it was moved to tests/phpunit/unit

Details

	Subject	Repo	Branch	Lines +/-
	Fix namespace for NewForm and NewLexeme	mediawiki/extensions/WikibaseLexemeCirrusSearch	master	+2 -2
	Move NewForm.php back to tests/phpunit/composer	mediawiki/extensions/WikibaseLexeme	master	+44 -41

Customize query in gerrit

Related Objects

Mentioned In: rEWLC8c54d904e038: Fix namespace for NewForm and NewLexeme

Event Timeline

dcausse created this task.Jul 29 2019, 10:47 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 29 2019, 10:47 AM

dcausse updated the task description. (Show Details)Jul 29 2019, 10:50 AM

dcausse added a project: Discovery-Search (Current work).

dcausse added a project: CirrusSearch.

Restricted Application edited projects, added Discovery-Search; removed Discovery-Search (Current work). · View Herald TranscriptJul 29 2019, 10:51 AM

Change 526127 had a related patch set uploaded (by DCausse; owner: DCausse):
[mediawiki/extensions/WikibaseLexeme@master] Move NewForm.php back to tests/phpunit/composer

https://gerrit.wikimedia.org/r/526127

gerritbot added a project: Patch-For-Review.Jul 29 2019, 10:54 AM

dcausse claimed this task.Jul 29 2019, 10:55 AM

dcausse triaged this task as Medium priority.

dcausse edited projects, added Discovery-Search (Current work); removed Discovery-Search.

dcausse updated the task description. (Show Details)

WMDE-leszek subscribed.Jul 29 2019, 11:34 AM

Why not fixing WikibaseLexemeCirrusSearch instead of reverting the change? (We searched in codesearch, is WikibaseLexemeCirrusSearch missing there?)

Change 526145 had a related patch set uploaded (by DCausse; owner: DCausse):
[mediawiki/extensions/WikibaseLexemeCirrusSearch@master] Fix namespace for NewForm and NewLexeme

https://gerrit.wikimedia.org/r/526145

In T229215#5372539, @Ladsgroup wrote:

Why not fixing WikibaseLexemeCirrusSearch instead of reverting the change? (We searched in codesearch, is WikibaseLexemeCirrusSearch missing there?)

Because I assumed that the Unit namespace was not exported making this classes invisible to WikibaseLexemeCirrusSearch, I've sent a patch there to use the new namespace.

Change 526127 abandoned by DCausse:
Move NewForm.php back to tests/phpunit/composer

Reason:
not needed, simply using the new namespace in WikibaseLexemeCirrusSearch worked

https://gerrit.wikimedia.org/r/526127

Thanks, this worked!
As for codesearch and WikibaseLexemeCirrusSearch I double checked and this project is available.

Change 526145 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexemeCirrusSearch@master] Fix namespace for NewForm and NewLexeme

https://gerrit.wikimedia.org/r/526145

Maintenance_bot removed a project: Patch-For-Review.Jul 29 2019, 3:10 PM

dcausse mentioned this in rEWLC8c54d904e038: Fix namespace for NewForm and NewLexeme.Jul 29 2019, 3:42 PM

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.16; 2019-07-30).Jul 29 2019, 4:00 PM

EBernhardson moved this task from Needs review to Needs Reporting on the Discovery-Search (Current work) board.Jul 30 2019, 12:14 AM

debt closed this task as Resolved.Jul 30 2019, 5:44 PM

CI fails for WikibaseLexemeCirrusSearch unit tests due to missing class exported by WikibaseLexemeClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

CI fails for WikibaseLexemeCirrusSearch unit tests due to missing class exported by WikibaseLexeme
Closed, ResolvedPublic
Actions