Page MenuHomePhabricator

VE edit cards broken by Minerva change
Closed, ResolvedPublic


Our edit cards use position:fixed, and a recent change to Minerva added a stacking context to .content, which triggers a known issue in Chrome that breaks the position:fixed.

Event Timeline

Change 529146 had a related patch set uploaded (by Niedzielski; owner: Stephen Niedzielski):
[mediawiki/skins/MinervaNeue@master] [fix] [Visual Editor] [LESS] [content] create stacking context differently

Change 529146 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] [fix] [Visual Editor] [LESS] [content] create stacking context differently

To clarify, the problem wasn't with a stacking context, it was with using transform: …; to create it. The fix is to instead use position: relative; z-index: …;.

I think using the latter is a good practice in general – while this is probably not a problem for Minerva, applying transforms also disables subpixel text rendering on Windows (making it appear blurry), and in general transforms are buggier than one would expect (in this case it was a bug in Chrome, but here's another recent example in Firefox: T224984).

matmarex added a project: Skipped QA.

Several people from both teams checked this, and I just verified once again that the patch definitely fixes it.

ppelberg claimed this task.