Class 'Wikibase\DataModel\Entity\ItemId' not found in various CI-related dockers
Open, Needs TriagePublic
Actions

Assigned To

None

Authored By

	sbassett
	Aug 13 2019, 9:29 PM

Description

Receiving the following exception:

14:00:24 [fbbabae76a18a58ae7657b6e] [no req]   Error from line 35 of /workspace/src/extensions/Wikibase/lib/WikibaseLib.entitytypes.php: Class 'Wikibase\DataModel\Entity\ItemId' not found
14:00:24 Backtrace:
14:00:24 #0 /workspace/src/extensions/Wikibase/repo/includes/WikibaseRepo.php(595): require()
14:00:24 #1 /workspace/src/extensions/Wikibase/repo/includes/WikibaseRepo.php(345): Wikibase\Repo\WikibaseRepo::getDefaultEntityTypes()
14:00:24 #2 /workspace/src/extensions/Wikibase/repo/includes/WikibaseRepo.php(401): Wikibase\Repo\WikibaseRepo::newInstance()
14:00:24 #3 /workspace/src/extensions/Wikibase/repo/RepoHooks.php(101): Wikibase\Repo\WikibaseRepo::getDefaultInstance()
14:00:24 #4 /workspace/src/includes/Hooks.php(174): Wikibase\RepoHooks::onSetupAfterCache()
14:00:24 #5 /workspace/src/includes/Hooks.php(202): Hooks::callHook(string, array, array, NULL)
14:00:24 #6 /workspace/src/includes/Setup.php(801): Hooks::run(string)
14:00:24 #7 /workspace/src/maintenance/doMaintenance.php(81): require_once(string)
14:00:24 #8 /workspace/src/maintenance/update.php(248): require_once(string)

Noticed for the following dockers:

mwext-php72-phan-seccheck-docker (example)
mwext-php72-phan-docker (example)

when working with a completely unrelated security backport for REL1_31, REL1_32 and REL1_33. I manually merged these since the patch for master tested fine (and the patch was one line of unrelated code for an entirely separate extension.)

It looks like this issue may have appeared within other contexts before? See: T201615, T209216.

Details

	Subject	Repo	Branch	Lines +/-
	Test Patch - DO NOT MERGE	mediawiki/extensions/MobileFrontend	REL1_31	+3 -1

Customize query in gerrit

Related Objects

Mentioned In: T209216: Wikibase cannot find a class on REL1_32
Mentioned Here: T189560: mediawiki/vendor REL1_* no longer ship dependencies for wmf extensions that are not in the mediawiki tarball
T201615: Wikibase on Vagrant: Class 'Wikibase\DataModel\Entity\ItemId' not found
T209216: Wikibase cannot find a class on REL1_32

Event Timeline

sbassett created this task.Aug 13 2019, 9:29 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 13 2019, 9:29 PM

hashar mentioned this in T209216: Wikibase cannot find a class on REL1_32.Sep 3 2019, 12:01 PM

Not sure if these release branches of Wikibase are supported. That'd be something for the Wikidata team to determine.

Restricted Application added a project: Wikidata. · View Herald TranscriptJun 25 2020, 5:05 PM

In T230451#6257384, @Jdforrester-WMF wrote:

Not sure if these release branches of Wikibase are supported. That'd be something for the Wikidata team to determine.

I suppose REL1_32 and REL1_33 are not of much concern anymore. This also might have been resolved elsewhere: T189560#5460674. So maybe this can be marked invalid or merged into that task?

REL1_31 is still reasonable to be supported, though. Not sure if the team are planning to do that?

Change 608081 had a related patch set uploaded (by SBassett; owner: SBassett):
[mediawiki/extensions/MobileFrontend@REL1_31] Test Patch - DO NOT MERGE

https://gerrit.wikimedia.org/r/608081

gerritbot added a project: Patch-For-Review.Jun 26 2020, 5:14 PM

sbassett removed a project: Patch-For-Review.Jun 26 2020, 5:20 PM

Hmm, well now I'm getting a phpunit error with quibble-composer-mysql-php72-noselenium-docker:

PHP Fatal error:  Cannot use 'object' as class name as it is reserved in /workspace/src/vendor/phpunit/phpunit-mock-objects/src/Generator.php(264) : eval()'d code on line 1
12:26:53

And the two dockers within the task description do not seem to be running against my test patch, guess they went away for REL1_31?

Change 608081 abandoned by SBassett:
[mediawiki/extensions/MobileFrontend@REL1_31] Test Patch - DO NOT MERGE

Reason:
Testing completed