Page MenuHomePhabricator

Alter gbw_reason/gb_reason/gbw_by_text on WMF production
Open, NormalPublic

Description

ALTER TABLE:

On centralauth run:

ALTER TABLE /*_*/globalblocks MODIFY gb_reason varbinary(767) NOT NULL;

https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/GlobalBlocking/+/532265/6/localdb_patches/patch-globalblocks-reason-length.sql


On every other wiki where the global_block_whitelist table exists (should be every wiki database)

ALTER TABLE /*_*/global_block_whitelist MODIFY gbw_reason varbinary(767) NOT NULL;

https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/GlobalBlocking/+/532265/6/localdb_patches/patch-global-block-whitelist-reason-length.sql


ALTER TABLE /*_*/global_block_whitelist MODIFY gbw_by_text varbinary(255) NOT NULL;

https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/GlobalBlocking/+/532271/2/localdb_patches/patch-global_block_whitelist-use-varbinary.sql

Which becomes a combined SQL query of...

ALTER TABLE /*_*/global_block_whitelist
MODIFY gbw_reason varbinary(767) NOT NULL,
MODIFY gbw_by_text varbinary(255) NOT NULL;

WHEN? At DBAs leisure

Backwards Compatible? Yes

Event Timeline

Reedy updated the task description. (Show Details)Sun, Aug 25, 7:33 PM

Thanks for following up

Marostegui added a subscriber: Marostegui.

Can you also paste the Gerrit link to the alter table?
https://wikitech.wikimedia.org/wiki/Schema_changes#Workflow_of_a_schema_change

I'm going to remove the Blocked-on-schema-change tag, as the patch isn't merged yet.
Please add it back once this is ready to go as the template paste above shows.
Sorry to be so strict but we prefer to follow that template to avoid any potential mistakes when doing alters in production :-)

Can you also paste the Gerrit link to the alter table?
https://wikitech.wikimedia.org/wiki/Schema_changes#Workflow_of_a_schema_change
I'm going to remove the Blocked-on-schema-change tag, as the patch isn't merged yet.
Please add it back once this is ready to go as the template paste above shows.
Sorry to be so strict but we prefer to follow that template to avoid any potential mistakes when doing alters in production :-)

Sure, its currently the patches at https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/GlobalBlocking/+/532265/

Reedy renamed this task from Extend gbw_reason/gb_reason on WMF production to Alter gbw_reason/gb_reason on WMF production.Sun, Aug 25, 8:11 PM
Reedy updated the task description. (Show Details)Sun, Aug 25, 8:19 PM
DannyS712 renamed this task from Alter gbw_reason/gb_reason on WMF production to Alter gbw_reason/gb_reason/gbw_by_text on WMF production.Sun, Aug 25, 8:33 PM
Reedy added a comment.Sun, Aug 25, 9:29 PM

Altered centralauth.globalblocks on beta. beta-update-databases-eqiad has updated the tables on the various wikis

Marostegui updated the task description. (Show Details)Mon, Aug 26, 5:57 AM
Marostegui updated the task description. (Show Details)
Marostegui triaged this task as Normal priority.
Marostegui updated the task description. (Show Details)