Page MenuHomePhabricator
Create Task
Maniphest T13543

Use CommentStore::COMMENT_CHARACTER_LIMIT everywhere
Closed, ResolvedPublic
Actions

Description

Comments used to be limited to 255 characters, a value that is hard-coded into multiple automatic edit summary truncation systems. Instead of relying on 225 (or not including a limit at all until the comment is actually saved), CommentStore::COMMENT_CHARACTER_LIMIT should be called instead.

Original proposal:
Could someone please add a global variable (eg $wgTruncatedCommentLength) for specifying the length that long summaries or auto-summaries are truncated to? There's three places in Article.php where this is done in the functions getBlankingAutosummary(), getAutosummary() and the end of delete().

Details

Reference
bz11543

Revisions and Commits

rARC Arcanist
rARCe69aa3260388 Fix an issue when rendering a lint message which removes whitespace at the end…
rARCfce72b9c89d7 Make lint tests handle paths better and distinguish between "0" and "null" more…
rARC25ee39b657b8 In the "cpplint" binding, raise messages on "line 0" without a line
rARC609c8c9fdc32 (stable) In the "cpplint" binding, raise messages on "line 0" without a line
rARC4aebaaf60895 (stable) Fix an issue when rendering a lint message which removes whitespace at…

Related Objects
Search...

Event Timeline

• bzimport raised the priority of this task from to Low.Nov 21 2014, 9:59 PM
• bzimport added a project: MediaWiki-Parser.
• bzimport set Reference to bz11543.
• bzimport added a subscriber: Unknown Object (MLST).
Nad created this task.Oct 2 2007, 9:01 PM
• brooke added a comment.Oct 2 2007, 11:18 PM

Note that they should all be truncated to the defined field length (255 bytes) fairly consistently, but it wouldn't hurt to use a global var here, per http://c2.com/cgi-bin/wiki?MagicNumber :)

DannyS712 claimed this task.Aug 21 2019, 11:08 PM
DannyS712 subscribed.

The maximum comment length is set at CommentStore::COMMENT_CHARACTER_LIMIT. In cases where the old hardcoded 255 (current is 500) are used, the comment store constant should be retrieved instead. I don't think a full global variable is needed here, since all uses of the limit are based around creating edit summaries and can just retrieve the comment store value. See also T221617

Restricted Application added a project: User-DannyS712. · View Herald TranscriptAug 21 2019, 11:08 PM
DannyS712 renamed this task from Replace hard-wired auto/truncated revision-summary length with a global to Replace hard-wired auto/truncated revision-summary length with CommentStore::COMMENT_CHARACTER_LIMIT.Aug 21 2019, 11:09 PM
DannyS712 updated the task description. (Show Details)
DannyS712 added a subtask: T221617: Automatic edit summaries should consider the full allowable edit summary length.
DannyS712 edited projects, added MediaWiki-Comment-store; removed MediaWiki-Parser.Aug 21 2019, 11:12 PM
DannyS712 moved this task from Unsorted to In progress on the User-DannyS712 board.Aug 22 2019, 9:48 AM
DannyS712 closed subtask T230962: Deletion auto-summary should use full summary length as Resolved.Aug 23 2019, 3:13 AM
DannyS712 added a subtask: T194588: Increase limit for edit summary in Flagged Revisions to COMMENT_CHARACTER_LIMIT.Aug 24 2019, 8:52 PM
DannyS712 closed subtask T231147: Use CommentStore::COMMENT_CHARACTER_LIMIT for maximum length in edit summaries as Resolved.Sep 2 2019, 7:23 PM
DannyS712 renamed this task from Replace hard-wired auto/truncated revision-summary length with CommentStore::COMMENT_CHARACTER_LIMIT to Use CommentStore::COMMENT_CHARACTER_LIMIT everywhere.Sep 30 2019, 5:49 AM
DannyS712 updated the task description. (Show Details)
DannyS712 added a subtask: T234174: Add missing `maxlength` attributes to text inputs that are truncated.
DannyS712 closed subtask T231146: Use CommentStore::COMMENT_CHARACTER_LIMIT for maximum length in Global Block reasons as Resolved.Oct 30 2019, 7:44 AM
Anomie closed subtask T194588: Increase limit for edit summary in Flagged Revisions to COMMENT_CHARACTER_LIMIT as Resolved.Nov 19 2019, 4:18 PM
DannyS712 added a subtask: T36467: Allow longer comments in RevDelete.Nov 22 2019, 6:59 PM
DannyS712 closed subtask T234174: Add missing `maxlength` attributes to text inputs that are truncated as Resolved.Jul 3 2020, 7:24 PM
epriestley added a commit: rARC4aebaaf60895: (stable) Fix an issue when rendering a lint message which removes whitespace at….Aug 13 2020, 9:38 PM
epriestley added a commit: rARC609c8c9fdc32: (stable) In the "cpplint" binding, raise messages on "line 0" without a line.
epriestley added a commit: rARC25ee39b657b8: In the "cpplint" binding, raise messages on "line 0" without a line.
epriestley added a commit: rARCe69aa3260388: Fix an issue when rendering a lint message which removes whitespace at the end….
epriestley added a commit: rARCfce72b9c89d7: Make lint tests handle paths better and distinguish between "0" and "null" more….
Jdforrester-WMF closed subtask T221617: Automatic edit summaries should consider the full allowable edit summary length as Resolved.Jun 28 2021, 1:14 PM
Tgr subscribed.Jul 7 2021, 8:11 PM

I expect this will be controversial for the same reason T6714: Epic: Increasing the length of the edit summary was.

Aklapper removed DannyS712 as the assignee of this task.Mar 13 2022, 7:55 PM
Aklapper subscribed.

Removing task assignee due to inactivity, as this open task has been assigned for more than two years. See the email sent to the task assignee on February 06th 2022 (and T295729).

Please assign this task to yourself again if you still realistically [plan to] work on this task - it would be welcome.

If this task has been resolved in the meantime, or should not be worked on ("declined"), please update its task status via "Add Action… 🡒 Change Status".

Also see https://www.mediawiki.org/wiki/Bug_management/Assignee_cleanup for tips how to best manage your individual work in Phabricator.

Umherirrender closed subtask T36467: Allow longer comments in RevDelete as Resolved.Jan 5 2023, 12:38 AM
Umherirrender closed this task as Resolved.Jan 5 2023, 12:40 AM
Umherirrender subscribed.

Many work were also done in T185948, looks fixed for core. When there are still places, please open a new task against the specific special page or action

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits