Page MenuHomePhabricator
Create Task
Maniphest T194588

Increase limit for edit summary in Flagged Revisions to COMMENT_CHARACTER_LIMIT
Closed, ResolvedPublic
Actions

Description

With T188798, the length of the edit summary was set to 500 characters for all Wikimedia wikis.

However, when using the button "Änderungen verwerfen" offered by Flagged Revisions (ID mw-fr-submit-reject), the edit summary is still limited to 200 characters, causing the well-known issues e.g. when reverting edits by anon users with IPv6 addresses, cf. this discussion on dewiki.

The length of this text field should also be set to 500:

<input name="wpReason" size="120" value="..." id="wpReason" maxlength="500" class="webfonts-changed">

Details

SubjectRepoBranchLines +/-
Use COMMENT_CHARACTER_LIMIT everywheremediawiki/extensions/FlaggedRevsmaster+8 -5
Customize query in gerrit

Related Objects
Search...

Event Timeline

Cirdan created this task.May 13 2018, 8:50 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 13 2018, 8:50 AM
Cirdan updated the task description. (Show Details)May 13 2018, 8:54 AM
Aklapper removed a project: MediaWiki-Page-editing.May 13 2018, 12:05 PM
gerritbot subscribed.May 13 2018, 1:19 PM

Change 432768 had a related patch set uploaded (by Cirdan; owner: Cirdan):
[mediawiki/extensions/FlaggedRevs@master] Increase maximum length of edit summary to 500 (T194588)

https://gerrit.wikimedia.org/r/432768

gerritbot added a project: Patch-For-Review.May 13 2018, 1:19 PM
Cirdan claimed this task.May 13 2018, 1:21 PM
Cirdan triaged this task as Medium priority.
Cirdan updated the task description. (Show Details)May 13 2018, 1:32 PM
Cirdan removed Cirdan as the assignee of this task.May 15 2018, 2:40 PM
Cirdan mentioned this in T185948: Update web UI for increased comment length.
• MichaelSchoenitzer_WMDE subscribed.May 15 2018, 2:47 PM
gerritbot added a comment.May 15 2018, 7:56 PM

Change 433210 had a related patch set uploaded (by Cirdan; owner: Cirdan):
[mediawiki/extensions/FlaggedRevs@master] Use COMMENT_CHARACTER_LIMIT everywhere (T194588)

https://gerrit.wikimedia.org/r/433210

Cirdan added a subscriber: Anomie.May 15 2018, 8:01 PM

@Anomie Thanks for the hint, I tried to add the COMMENT_CHARACTER_LIMIT in all places, but I don't feel qualified to work on this further.

As far as I could figure out, the wpReason comment is only added to the log tables, which should be ready for longer comments. If, however, FlaggedRevs also stores the comments in one of its own tables, the database schema needs to be adapted and the table updated accordingly before any change can go into effect.

• Vvjjkkii renamed this task from Increase limit for edit summary in Flagged Revisions to 500 to 31caaaaaaa.Jul 1 2018, 1:11 AM
• Vvjjkkii raised the priority of this task from Medium to High.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed subscribers: gerritbot, Aklapper.
CommunityTechBot renamed this task from 31caaaaaaa to Increase limit for edit summary in Flagged Revisions to 500.Jul 2 2018, 5:40 AM
CommunityTechBot lowered the priority of this task from High to Medium.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
CommunityTechBot added subscribers: gerritbot, Aklapper.
MGChecker subscribed.Aug 23 2019, 9:39 PM
MGChecker added a comment.Aug 23 2019, 9:49 PM

As far as I could figure out, the wpReason comment is only added to the log tables, which should be ready for longer comments. If, however, FlaggedRevs also stores the comments in one of its own tables, the database schema needs to be adapted and the table updated accordingly before any change can go into effect.

I' took a look at the flaggedrevs tables and there is no row where these could possibly go to.

gerritbot added a comment.Aug 24 2019, 1:03 PM

Change 432768 abandoned by MarcoAurelio:
Increase maximum length of edit summary to 500 (T194588)

https://gerrit.wikimedia.org/r/432768

gerritbot added a comment.Aug 24 2019, 6:12 PM

Change 532090 had a related patch set uploaded (by MGChecker; owner: Cirdan):
[mediawiki/extensions/FlaggedRevs@master] Use COMMENT_CHARACTER_LIMIT everywhere (T194588)

https://gerrit.wikimedia.org/r/532090

DannyS712 added a parent task: T13543: Use CommentStore::COMMENT_CHARACTER_LIMIT everywhere.Aug 24 2019, 8:52 PM
gerritbot added a comment.Aug 24 2019, 10:25 PM

Change 532090 had a related patch set uploaded (by MGChecker; owner: Cirdan):
[mediawiki/extensions/FlaggedRevs@master] Use COMMENT_CHARACTER_LIMIT everywhere

https://gerrit.wikimedia.org/r/532090

Reedy renamed this task from Increase limit for edit summary in Flagged Revisions to 500 to Increase limit for edit summary in Flagged Revisions to COMMENT_CHARACTER_LIMIT.Aug 25 2019, 7:39 PM
Count_Count subscribed.Aug 29 2019, 5:34 PM
MGChecker added a project: Platform Engineering.Sep 23 2019, 12:05 PM

Adding Core Platform, as they are responsible for MediaWiki-Comment-store and might be able to assist with reviewing here.

Anomie moved this task from Inbox to Feature Requests to Review on the Platform Engineering board.Sep 23 2019, 1:27 PM
Anomie edited projects, added Platform Team Workboards (Clinic Duty Team); removed Platform Engineering.
Anomie moved this task from Inbox to External Code Review Needed on the Platform Team Workboards (Clinic Duty Team) board.
MarcoAurelio subscribed.Sep 23 2019, 9:21 PM

Do we need some schema changes or ALTERs on prod before merging https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/FlaggedRevs/+/532090/ ?

Anomie added a comment.Sep 24 2019, 5:25 PM

I don't see any schema changes in that patch, just changes to HTML form field "maxlength" parameters. Also at a quick glance I don't see anything that looks like a comment field in the extension's schema, while I do see it seeming to hand the supplied texts to core functions.

MGChecker added a comment.Sep 24 2019, 9:11 PM

By T194588#5434893, there is no row in the extension schema where this information could possibly go to.

Anomie moved this task from External Code Review Needed to External Code Review Completed on the Platform Team Workboards (Clinic Duty Team) board.Nov 19 2019, 3:39 PM
gerritbot added a comment.Nov 19 2019, 3:49 PM

Change 532090 merged by jenkins-bot:
[mediawiki/extensions/FlaggedRevs@master] Use COMMENT_CHARACTER_LIMIT everywhere

https://gerrit.wikimedia.org/r/532090

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.8; 2019-11-26).Nov 19 2019, 4:00 PM
Anomie closed this task as Resolved.Nov 19 2019, 4:18 PM
Anomie assigned this task to MGChecker.
Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:41 PM
gerritbot added a comment.Nov 10 2020, 2:23 PM

Change 433210 abandoned by Thiemo Kreuz (WMDE):
[mediawiki/extensions/FlaggedRevs@master] Use COMMENT_CHARACTER_LIMIT everywhere (T194588)

Reason:
Obsolete via I5dbc0ab, which is merged.

https://gerrit.wikimedia.org/r/433210

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits