Page MenuHomePhabricator

missing {{col-end}} breaks collapsing section functionality on mobile devices
Closed, DeclinedPublic


Steps to Reproduce:

  1. Create a document with multiple sections one of which has a {{col-begin}} with no corresponding {{col-end}}.
  2. Look at the document on a mobile device.

Actual result: In collapsed view, no sections are visible beyond the section with the missing {{col-end}}. If that section is expanded, all the later sections are visible, but they can't be collapsed or expanded individually.

Expected Result:
Document displays an error message that {{col-end}} is missing, OR this error is handled somehow, e.g., by automatically ending the multi-column table at the end of the section.

For an example of this see

Related Objects

Event Timeline

Jdlrobson added a subscriber: Jdlrobson.

If an article is using an unbalanced template in this fashion it is creating invalid HTML then it is breaking the HTML of the page and likely has other problems.
See T114445 for more details about balanced templates.

This is a wont fix from our side and ideally would be fixed on the parser level (tagging that team in case there's something they can do here e.g. flag a page to MobileFrontend not to do section collapsing).

TheDJ claimed this task.
TheDJ added a subscriber: TheDJ.

I don't see the problem. If you break the html, other things are going to break. Don't break the html.

Aklapper changed the task status from Resolved to Declined.Aug 29 2021, 11:15 AM
Aklapper removed TheDJ as the assignee of this task.